Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade miniflare to 3.0.1 #3454

Merged
merged 1 commit into from
Jun 13, 2023
Merged

chore: upgrade miniflare to 3.0.1 #3454

merged 1 commit into from
Jun 13, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Jun 13, 2023

Fixes #3264
Fixes #3218

Supersedes #3352

What this PR solves / how to test:

This PR bumps the minimum miniflare version to 3.0.1, fixing some HTTPS fetch() issues.

Associated docs issue(s)/PR(s):

N/A

Author has included the following, where applicable:

Reviewer is to perform the following, as applicable:

  • Checked for inclusion of relevant tests
  • Checked for inclusion of a relevant changeset
  • Checked for creation of associated docs updates
  • Manually pulled down the changes and spot-tested

@mrbbot mrbbot requested review from a team as code owners June 13, 2023 16:36
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

🦋 Changeset detected

Latest commit: c86f8d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/pages-shared Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5258106687/npm-package-wrangler-3454

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/3454/npm-package-wrangler-3454

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5258106687/npm-package-wrangler-3454 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/5258106687/npm-package-cloudflare-pages-shared-3454

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #3454 (c86f8d7) into main (8414964) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3454      +/-   ##
==========================================
+ Coverage   75.17%   75.21%   +0.04%     
==========================================
  Files         183      183              
  Lines       11052    11052              
  Branches     2904     2904              
==========================================
+ Hits         8308     8313       +5     
+ Misses       2744     2739       -5     

see 3 files with indirect coverage changes

@mrbbot mrbbot merged commit a219404 into main Jun 13, 2023
@mrbbot mrbbot deleted the bcoll/miniflare-3.0.1 branch June 13, 2023 17:31
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
lrapoport-cf pushed a commit that referenced this pull request Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants