This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
Add retries for targeting CF CLI #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/174125875 The labels on this github issue will be updated when the story is started. |
mike1808
commented
Jul 31, 2020
|
|
||
| until [ "${i}" -ge "${tries}" ] | ||
| do | ||
| eval "${command}" && break |
There was a problem hiding this comment.
tested that eval interpolates exported variables
tcdowney
approved these changes
Jul 31, 2020
routing-ci
pushed a commit
that referenced
this pull request
Sep 15, 2020
Add option to skip ssl validation to smoke test [finishes #171721317](https://www.pivotaltracker.com/story/show/171721317) Co-authored-by: John Ryan <jryan@pivotal.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I noticed that after deploying environment
cf apicommand always fails. I don't know the reasons but probably it's something about DNS propagation and DNS cache invalidation. Adding retries here sounded like a good solution.