New ADR fresh out of the oven! #68
Conversation
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/174832650 The labels on this github issue will be updated when the story is started. |
[#174370911](https://www.pivotaltracker.com/story/show/174370911) Co-authored-by: Mikael Manukyan <mmanukyan@vmware.com>
|
|
||
| ## Context | ||
|
|
||
| This ADR reverts the decision made in [ADR # 7. Maintain Generated |
There was a problem hiding this comment.
Maybe insert the word partially here? We're still maintaining the generated Istio config it's just living in another place.
Also more generally this ADR should comment on our decision that we will be responsible for this config despite it being in a repo we don't directly control.
| * move Istio config generation and overlays folder `istio-install` | ||
| * move Istio generated and other networking config folders `config/istio`, | ||
| `config/istio-generated` | ||
| * when contributing to networking in cf-for-k8s open PR and tag it with |
There was a problem hiding this comment.
Why? (I think I know why but it would be helpful to have it in the ADR).
| `config/istio-generated` | ||
| * when contributing to networking in cf-for-k8s open PR and tag it with | ||
| `networking` tag | ||
| * create CI job to run acceptance tests upon new networking PRs in cf-for-k8s |
There was a problem hiding this comment.
I wonder if we should talk about our decision to keep NATs in our repo (and i think our pipeline in our concourse right?), or if that's a separate ADR 🤔
There was a problem hiding this comment.
I would say put it in this one. IMO the decision to keep them in our repo only means something in the context of moving istio config out of our repo
|
|
||
| ## Decision | ||
|
|
||
| Relint and Networking came to a consensus to do move Istio configuration to |
There was a problem hiding this comment.
I think the word "do" is unnecessary in this sentence. "...consensus to do..." > "...consensus to..."
|
|
||
| * move Istio config generation and overlays folder `istio-install` | ||
| * move Istio generated and other networking config folders `config/istio`, | ||
| `config/istio-generated` |
There was a problem hiding this comment.
few things we could add if you think it'll be useful: 1. how the overlays directly related to istio installation are in the build/istio folder and any other overlays/config is in config/istio, and 2. how to make "data values" for istio using starlark functions
There was a problem hiding this comment.
Hey @ndhanushkodi we added some changes after your recommendation. Could you please take a look and let us know what you think? Thanks
|
|
||
| ## Decision | ||
|
|
||
| Relint and Networking came to a consensus to do move Istio configuration to |
There was a problem hiding this comment.
the word Relint might not well known in the community :) maybe we can use a more standard name for this.
Co-authored-by: Kauana dos Santos <kdossantos@vmware.com>
New ADR to reflect the decision to move Istio config to cf-for-k8s.
Additional Context
Related Story
Tag your pair, your PM, and/or team
@mike1808