Skip to content

Commit

Permalink
doc: Fix a dependency version pinning comment
Browse files Browse the repository at this point in the history
- Removed the mention of an old specific grpc version in the pinning comment.
  • Loading branch information
hsinn0 committed Sep 12, 2024
1 parent 77f916f commit c23d0f4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ updates:
- dependency-name: "org.springframework.boot:*"
update-types: [ "version-update:semver-major" ] # Bump this after we bump to Java 17, which v3 requires (and the current v2 will be supported until November 2023: https://spring.io/blog/2022/05/24/preparing-for-spring-boot-3-0)
- dependency-name: "com.google.protobuf:protoc"
update-types: [ "version-update:semver-major" ] # We need to stay with protobuf-java & protoc 3.25.x as the latest grpc 1.62.2 still depends on protobuf-java & protoc 3.25.x https://github.com/grpc/grpc-java/issues/11015
update-types: [ "version-update:semver-major" ] # We need to stay with protobuf-java & protoc 3.25.x as the latest grpc still depends on protobuf-java & protoc 3.25.x https://github.com/grpc/grpc-java/issues/11015
- dependency-name: "com.google.protobuf:protobuf-java"
update-types: [ "version-update:semver-major" ] # We need to stay with protobuf-java & protoc 3.25.x as the latest grpc 1.62.2 still depends on protobuf-java & protoc 3.25.x https://github.com/grpc/grpc-java/issues/11015
update-types: [ "version-update:semver-major" ] # We need to stay with protobuf-java & protoc 3.25.x as the latest grpc still depends on protobuf-java & protoc 3.25.x https://github.com/grpc/grpc-java/issues/11015


- package-ecosystem: "github-actions"
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ buildscript {
snakeyamlVersion = '2.3'
grpcVersion = '1.66.0'
// We need to stay with protobuf-java & protoc 3.25.x as the latest
// grpc 1.62.2 still depends on protobuf-java & protoc 3.25.x. Once we
// grpc still depends on protobuf-java & protoc 3.25.x. Once we
// bump grpc to version that depnds on protobuf-java & protoc to 4.x.x,
// it is likely that we are going to get conflicts because we also have
// direct dependency to protobuf 3.25.x. We will need to bump protobuf
Expand Down

0 comments on commit c23d0f4

Please sign in to comment.