fix invalid metrics panic

cloudonly · Sep 28, 2023 · 40c0a43 · 40c0a43
1 parent 43f34c9
commit 40c0a43
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/pkg/exporter/probe/metrics.go b/pkg/exporter/probe/metrics.go
@@ -114,7 +114,12 @@ func (b *BatchMetrics) Collect(metrics chan<- prometheus.Metric) {
 			log.Errorf("%s undeclared metrics %s", b.name, name)
 			return
 		}
-		metrics <- prometheus.MustNewConstMetric(info.desc, info.valueType, val, labels...)
+		m, err := prometheus.NewConstMetric(info.desc, info.valueType, val, labels...)
+		if err != nil {
+			log.Errorf("%s failed create metrics, err: %v", b.name, err)
+			return
+		}
+		metrics <- m
 	}
 
 	err := b.ProbeCollector(emit)