Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gh-actions to check and fix license headers #10

Merged
merged 28 commits into from
Mar 16, 2024

Conversation

kengou
Copy link
Contributor

@kengou kengou commented Mar 11, 2024

Add a new GitHub Actions Workflow:

  • Check & Fix License Header

cmd/tcp-proxy/main.go Outdated Show resolved Hide resolved
pkg/apis/scheme_builder.go Outdated Show resolved Hide resolved
@auhlig
Copy link
Member

auhlig commented Mar 11, 2024

Cool!

@auhlig
Copy link
Member

auhlig commented Mar 11, 2024

@auhlig auhlig self-requested a review March 15, 2024 15:51
@auhlig auhlig merged commit 4cc4898 into main Mar 16, 2024
3 checks passed
@auhlig auhlig deleted the feat/license-header branch March 16, 2024 23:48
- '**/*.lock'
- '**/*.json'
- '**/.gitkeep'
- '**/*.jsx'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kengou I just saw that you excluded .jsx files from being commented. What is the reason for that? We have a lot of files in our project which are written in .jsx files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @hodanoori! .jsx files should not be excluded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing it in #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants