generated from cloudoperators/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/UI/introduce plugin overview #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: extract ClusterSelect component
* refactor: Extract OptionInput component
* Refactor + style MarkDown
…perators/greenhouse into feat/ui/introduce-plugin-overview
…perators/greenhouse into feat/ui/introduce-plugin-overview
uwe-mayer
requested review from
auhlig,
IvoGoman,
kengou,
onuryilmaz,
andypf,
ArtieReus,
edda,
hodanoori and
TilmanHaupt
as code owners
May 23, 2024 11:16
TilmanHaupt
approved these changes
May 23, 2024
kengou
reviewed
May 23, 2024
auhlig
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following updates to the
PluginDefinitions
type:displayName
: A human-readable label for the pluginDefinition.docMarkDownUrl
: An URL to the markdown documentation file for thisPluginDefinition
icon
: Icon specifies the icon to be used for thisPluginDefinition
in the Greenhouse UI. Icons can be either:And some features to the
plugin-admin
view:PluginDefinitions
overview asAvailable Plugins
TabPluginDefinition
detail viewPlugin
edit/create view, currently accessible fromConfigure Plugin
button within aPluginDefinition
detail viewPlugin
from theEnabled Plugins
List within aPluginDefinition
viewView README on instructions on how to spin up the ui with local mock resources representing all introduced changes.
The former
plugindefinition-admin
has been merged into theplugin-admin
the "least intrusive way".A couple of todos still need attention (not exclusive!):
secret
from aOptionValue
with type secretedit
screen from thePlugin
detail viewAvailable Plugins
tab with respectivePlugin
detail after successfulPlugin
create/updatePanel
open withinPluginDefinition
screensPlugin
Plugin
detail view.Plugins
instead of getting, so we get updates without browser reloadPlugin
object (see here)PluginDefinition
detail view.TODO
s in code before mergingdocker-compose
image tags tomain
before merging.Unchecked boxes are moved to post MVP here:
#152