Fix(ui): falsy string comparison + dot in option identifiers #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: extract ClusterSelect component
* refactor: Extract OptionInput component
* Refactor + style MarkDown
…perators/greenhouse into feat/ui/introduce-plugin-overview
…perators/greenhouse into feat/ui/introduce-plugin-overview
uwe-mayer
requested review from
auhlig,
IvoGoman,
kengou,
onuryilmaz,
andypf,
ArtieReus,
edda,
hodanoori and
TilmanHaupt
as code owners
|
Superseeded by #235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that check mark value changes were not reflected in Plugin updates on boolean values.
This was due to the fact that Javascript compares
and we did not expect OptionValues to have dots in their identifiers as in e.g.
alerts.alertmanager.enabled