refac(teamrbac): introduce helpers for testing #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
requested review from
auhlig,
kengou,
onuryilmaz and
uwe-mayer
as code owners
Co-authored-by: Uwe Mayer <115539431+uwe-mayer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in
test.TestSetup(..)which provides some convenience around creating resources in dedicated namespace. Together with helper methods to create resources (e.g.CreateTeamRoleBinding(..)orOnboardCluster(..)this should help to reduce the manifest boilerplate required to create resources during test setups.The test restructuring also unveiled missing propagation of errors when the reconciliation failed. They are now returned.