feat(rbac): replace clusterSelector with clusterName #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
IvoGoman
commented
Mar 21, 2024
IvoGoman
commented
- replace ClusterSelector by ClusterName
- ensure Role exists when creating RoleBinding
IvoGoman
requested review from
auhlig,
kengou,
onuryilmaz and
uwe-mayer
as code owners
kengou
approved these changes
Mar 22, 2024
IvoGoman
force-pushed
the
feat/rbacenhancements
branch
from
9112d37
to
8f9542c
Compare
IvoGoman
requested review from
andypf,
ArtieReus,
edda,
hodanoori,
TilmanHaupt and
a team
as code owners
github-actions
bot
added
documentation
- activate Greenhouse RoleBinding controller - replace clusterSelector with clusterName - ensure Greenhouse Role exists during RB creation - ensure Namespaces on Remote Cluster exist during RB creation
IvoGoman
force-pushed
the
feat/rbacenhancements
branch
from
8f9542c
to
2af9224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.