Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets-admin): No watch if unauthorized + some refactoring #300

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

uwe-mayer
Copy link
Contributor

@uwe-mayer uwe-mayer commented Jun 18, 2024

Description

This PR fixes #293
and refactors:

  • use messages-provider instead of custom component
  • correctly reset secretDetail after update

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@uwe-mayer uwe-mayer requested a review from a team as a code owner June 18, 2024 07:49
@github-actions github-actions bot added the ui label Jun 18, 2024
ArtieReus
ArtieReus previously approved these changes Jun 18, 2024
Copy link
Contributor

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks!!

ui/secret-admin/package.json Show resolved Hide resolved
@ArtieReus ArtieReus dismissed their stale review June 18, 2024 08:06

wrong clicked

…om:cloudoperators/greenhouse into fix/secrets-admin/no-watch-if-unauthorized
Copy link
Contributor

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@uwe-mayer uwe-mayer merged commit 81d430d into main Jun 18, 2024
7 checks passed
@uwe-mayer uwe-mayer deleted the fix/secrets-admin/no-watch-if-unauthorized branch June 18, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - (ui) watches on unauthorized objects throw constant errors
2 participants