Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(teamrbac): Remove cluster existence check #362

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

IvoGoman
Copy link
Contributor

Description

The cluster existence check has been removed from TeamRoleBinding Admission. With the clusterSelector it cannot be ensured that this always matches. The controller is returning appropriate events and errors during reconciliation. The existence check blocks editing if the cluster no longer exists.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

The cluster existence check has been removed from TeamRoleBinding Admission.
With the clusterSelector it cannot be ensured that this always matches.
The controller is returning appropriate events and errors during reconciliation.
The existence check blocks editing if the cluster no longer exists.
@IvoGoman IvoGoman requested a review from a team as a code owner July 12, 2024 15:33
@IvoGoman IvoGoman merged commit 76e3e15 into main Jul 15, 2024
5 checks passed
@IvoGoman IvoGoman deleted the fix/teamrbac-admission branch July 15, 2024 11:52
@IvoGoman IvoGoman mentioned this pull request Jul 16, 2024
26 tasks
ArtieReus pushed a commit that referenced this pull request Jul 17, 2024
The cluster existence check has been removed from TeamRoleBinding Admission.
With the clusterSelector it cannot be ensured that this always matches.
The controller is returning appropriate events and errors during reconciliation.
The existence check blocks editing if the cluster no longer exists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants