fix: reconcile error message not set #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoGoman
force-pushed
the
fix/reconcileerrmsg
branch
from
fd184d4
to
d2d56df
Compare
IvoGoman
force-pushed
the
fix/reconcileerrmsg
branch
from
d2d56df
to
b0cb356
Compare
IvoGoman
force-pushed
the
fix/reconcileerrmsg
branch
from
5e5adb7
to
979a391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message is retrieved from the
HelmReconcileFailedCondition. This broke when theHelmDriftDetectionwas added.Adds test case to ensure UI only plugins are reconciled correctly.