Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slow_start parameter to target group #104

Merged
merged 4 commits into from
May 3, 2022
Merged

Add slow_start parameter to target group #104

merged 4 commits into from
May 3, 2022

Conversation

plenkl
Copy link
Contributor

@plenkl plenkl commented Sep 21, 2021

what

  • Exposes the parameter slow_start which controls how the load balancer scales in new targets as they become healthy.

why

  • Some applications need time to warm up before they can start handling their full share of requests.

references

@plenkl plenkl requested review from a team as code owners September 21, 2021 13:44
@plenkl plenkl requested review from jhosteny and RothAndrew and removed request for a team September 21, 2021 13:44
@nitrocode
Copy link
Member

/test all

nitrocode
nitrocode reviewed Sep 23, 2021
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
plenkl and others added 2 commits September 23, 2021 16:18
@plenkl @nitrocode
Use null instead of 0 as default value
33a9a40 
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
@cloudpossebot
Auto Format
f29edda
@nitrocode
Copy link
Member

/test all

@ikarlashov
Copy link

Any updates?

@Gowiem
Copy link
Member

Gowiem commented May 3, 2022

/test all

Gowiem
Gowiem approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Gowiem Gowiem enabled auto-merge (squash) May 3, 2022 16:31
@Gowiem Gowiem merged commit ef40bb7 into cloudposse:master May 3, 2022
@Gowiem
Copy link
Member

Gowiem commented May 3, 2022

@plenkl Thanks for the contribution! Released as https://github.com/cloudposse/terraform-aws-alb/releases/tag/1.1.0

SatyaVadapalli pushed a commit to teamclairvoyant/terraform-aws-alb that referenced this pull request Jun 29, 2022
@plenkl @nitrocode
@cloudpossebot @Gowiem @SatyaVadapalli
Add slow_start parameter to target group (cloudposse#104)
c686b73 
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: Matt Gowie <gowie.matt@gmail.com>
SatyaVadapalli pushed a commit to teamclairvoyant/terraform-aws-alb that referenced this pull request Jun 29, 2022
@plenkl @nitrocode
@cloudpossebot @Gowiem @SatyaVadapalli
Add slow_start parameter to target group (cloudposse#104)
4f0f4ad 
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: Matt Gowie <gowie.matt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@Gowiem Gowiem Gowiem approved these changes

@jhosteny jhosteny Awaiting requested review from jhosteny

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@plenkl @nitrocode @ikarlashov @Gowiem @cloudpossebot