feat: add variable to support health check protocol different from traffic's #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topikachu
requested review from
adamcrews and
brcnblc
and removed request for
a team
|
/test all |
Gowiem
approved these changes
May 19, 2022
Gowiem
changed the title
SatyaVadapalli
pushed a commit
to teamclairvoyant/terraform-aws-alb
that referenced
this pull request
Jun 29, 2022
…affic's (cloudposse#117) Co-authored-by: gongy <yi.gong@microfocus.com> Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add variable to support health check protocol different from traffic's
why
My system uses HTTP for the health check but HTTPS for data traffic.
Add a new variable to support this use case.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb_target_group#health_check