Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attribute protocol_version into default target group #118

Merged
merged 4 commits into from
Jun 20, 2022
Merged

Add attribute protocol_version into default target group #118

merged 4 commits into from
Jun 20, 2022

Conversation

ArtemKorchunov
Copy link
Contributor

what

  • Add attribute protocol_version to default target group

why

@ArtemKorchunov ArtemKorchunov requested review from a team as code owners June 20, 2022 05:16
@ArtemKorchunov ArtemKorchunov requested review from dotCipher and srhopkins and removed request for a team June 20, 2022 05:16
@ArtemKorchunov ArtemKorchunov changed the title Add target_group_protocol_version_attr Add attribute protocol_version into default target group Jun 20, 2022
@joe-niland
Copy link
Sponsor Member

Hi @ArtemKorchunov

This arg was added in v3.27.0 so we'll have to bump the minimum AWS provider version as well.

@ArtemKorchunov
Copy link
Contributor Author

Hi @joe-niland. I see, so I am going to close this pr for now as I suspect that bumping up min version is not something that you would like to do for just one attribute. Correct?

@joe-niland
Copy link
Sponsor Member

Hi @ArtemKorchunov

Sorry, I was not clear.
It's fine to bump the provider (to an extent) because we'll also bump the version of this module so as not to break consumers' modules, assuming they've used version pinning.

I just meant you can make that change in versions.tf and then we can run the tests.

@ArtemKorchunov
Copy link
Contributor Author

@joe-niland Sure thing, here it is.

@joe-niland
Copy link
Sponsor Member

/test all

@joe-niland joe-niland added the minor New features that do not break anything label Jun 20, 2022
@joe-niland joe-niland self-requested a review June 20, 2022 10:34
@joe-niland joe-niland merged commit 5296fdb into cloudposse:master Jun 20, 2022
@ArtemKorchunov ArtemKorchunov deleted the Add_target_group_protocol_version_attr branch June 20, 2022 10:35
@joe-niland
Copy link
Sponsor Member

Thanks for your contribution @ArtemKorchunov

SatyaVadapalli pushed a commit to teamclairvoyant/terraform-aws-alb that referenced this pull request Jun 29, 2022
@ArtemKorchunov @cloudpossebot @SatyaVadapalli
Add attribute protocol_version into default target group (cloudposse#118
69f49bb 
)

* Add target_group_protocol_version_attr

* Bump aws hashicorp min version

* Auto Format

Co-authored-by: ArtemKorchunov <artem.korchunov@axora.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-niland joe-niland joe-niland approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArtemKorchunov @joe-niland @cloudpossebot