-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo #3
fix typo #3
Conversation
main.tf
Outdated
@@ -26,7 +26,7 @@ resource "aws_security_group_rule" "egress" { | |||
} | |||
|
|||
resource "aws_security_group_rule" "http_ingress" { | |||
count = "${var.http_enabled}" | |||
count = "${var.http_enabled ? 1 : 0}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use explicit comparison: var.http_enabled == "true"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure http_enabled
is a string. boolean variables in TF are not recommended by terraform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
what
Fix a typo in variable description key.
why
Allow module to be pulled and instantiated without error.