feature(access_logs): make possible to specify an external s3 bucket … #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scream314
requested review from
Makeshift and
jamengual
and removed request for
a team
SweetOps
previously requested changes
Mar 4, 2021
main.tf
Outdated
| @@ -39,6 +39,8 @@ resource "aws_security_group_rule" "https_ingress" { | |||
| } | |||
|
|
|||
| module "access_logs" { | |||
| count = var.access_logs_s3_bucket_id == "" ? 1 : 0 | |||
|
|
|||
| source = "cloudposse/lb-s3-bucket/aws" | |||
| version = "0.11.4" | |||
| enabled = module.this.enabled && var.access_logs_enabled | |||
There was a problem hiding this comment.
no reasons to add count you can just extend condition in the enabled
adamantike
reviewed
Mar 26, 2021
|
@scream314, let us know if you can keep working on this. I can take it, otherwise. |
|
@adamantike I hope I can address the change requests next week. I added a reminder in my calendar for Wednesday. |
scream314
force-pushed
the
77-external-logging-bucket
branch
from
d885c92
to
64906e6
Compare
|
This pull request is now in conflict. Could you fix it @scream314? 🙏 |
mergify
bot
dismissed
SweetOps’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
scream314
force-pushed
the
77-external-logging-bucket
branch
from
7db6f0b
to
773f223
Compare
|
This pull request is now in conflict. Could you fix it @scream314? 🙏 |
|
@SweetOps, I think this is ready for another review! |
|
/test all |
|
This pull request is now in conflict. Could you fix it @scream314? 🙏 |
|
/test all |
Gowiem
approved these changes
Apr 10, 2021
|
Thanks @scream314 -- released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for logs
what
access_logsmodule is skipped.why
references