Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow var access_logs_enabled = false without having to set a bucket id #87

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Allow var access_logs_enabled = false without having to set a bucket id #87

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1360f3
set access_logs bucket differently to allow no values set for bucket ids
joe-niland Apr 15, 2021
7b83cb4
Add test for no access logs
joe-niland Apr 15, 2021
7bd1d55
revert test Makefile change
joe-niland Apr 15, 2021
860bc3b
Remove test for no access logs
joe-niland Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
set access_logs bucket differently to allow no values set for bucket ids
  • Loading branch information
@joe-niland
joe-niland committed Apr 15, 2021
commit e1360f317af9cb238bb7ae19b1dbcbedfed017d5
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ resource "aws_lb" "default" {
drop_invalid_header_fields = var.drop_invalid_header_fields

access_logs {
bucket = coalesce(var.access_logs_s3_bucket_id, module.access_logs.bucket_id)
bucket = try(element(compact([var.access_logs_s3_bucket_id, module.access_logs.bucket_id]), 0), "")
prefix = var.access_logs_prefix
enabled = var.access_logs_enabled
}
Expand Down