Ensure target group and load balancer names cannot exceed their max length

[nitrocode]

what

• Ensure target group and load balancer names cannot exceed their max length
• Expose *_max_length variables in case AWS changes their max length in the future
• Override load_balancer_name, similar to target_group_name

why

• To prevent exceeding the max lengths of the tg and lb so the module will be applied correctly

references

• Closes ALB target group name is limited to 32 characters #27
• API_CreateTargetGroup

  This name must be unique per region per account, can have a maximum of 32 characters, must contain only alphanumeric characters or hyphens, and must not begin or end with a hyphen.

• API_CreateLoadBalancer

  This name must be unique per region per account, can have a maximum of 32 characters, must contain only alphanumeric characters or hyphens, must not begin or end with a hyphen, and must not begin with "internal-".

[bridgecrew]

Bridgecrew has found 1 infrastructure configuration error in this PR ⬇️

[bridgecrew]

  Ensure that ALB redirects HTTP requests into HTTPS ones
    Resource: aws_lb.default | ID: BC_AWS_NETWORKING_49

How to Fix

resource "aws_lb" "lb_good" {
}


resource "aws_lb_listener" "listener_good" {
  load_balancer_arn = aws_lb.lb_good.arn
  port              = "80"
  protocol          = "HTTP"

  default_action {
    type = "redirect"

    redirect {
      port        = "443"
      protocol    = "HTTPS"
      status_code = "HTTP_301"
    }

  }
}

Description

TBA

Dependent Resources

Path	Resource	Connecting Attribute
/main.tf	aws_lb_listener.http_forward	load_balancer_arn
/main.tf	aws_lb_listener.http_redirect	load_balancer_arn
/main.tf	aws_lb_listener.https	load_balancer_arn

[nitrocode]

/test all

[mergify]

This pull request is now in conflict. Could you fix it @nitrocode? 🙏

[nitrocode]

/test all