Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use security-group module instead of resource #114

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Conversation

SweetOps
Copy link
Contributor

what

  • use security-group module instead of resource
  • update tests

why

  • more flexible than current implementation
  • bring configuration of security group/rules to one standard

references

  • CPCO-409

@SweetOps SweetOps requested review from a team as code owners May 25, 2021 16:41
@SweetOps SweetOps marked this pull request as draft May 25, 2021 16:42
@SweetOps
Copy link
Contributor Author

/test all

@SweetOps
Copy link
Contributor Author

/test all

@SweetOps SweetOps marked this pull request as ready for review May 25, 2021 17:52
@nitrocode
Copy link
Member

/test all

@SweetOps SweetOps merged commit 2b3eecb into master Jun 15, 2021
@SweetOps SweetOps deleted the CPCO-409 branch June 15, 2021 17:03
@z0rc
Copy link
Contributor

z0rc commented Jun 22, 2021

When upgrading module for existing cluster to this version, the change triggers security group recreation, which triggers EKS cluster recreation. Which is really not an expected thing to happen on minor version bump. I had to do manual

terraform state mv 'module.eks.aws_security_group.default[0]' 'module.eks.module.security_group.aws_security_group.default[0]'

to keep terraform from recreating half of the stack.

Just a small request to maintainers be a bit more mindful about upgrade paths.

Nuru added a commit that referenced this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants