Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform 0.14 upgrade #86

Merged
merged 9 commits into from
Dec 13, 2020
Merged

Terraform 0.14 upgrade #86

merged 9 commits into from
Dec 13, 2020

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented Dec 9, 2020 •
edited
Loading

what

  • Standard Terraform 0.14 upgrade

why

  • Support Terraform 0.14
  • Update to current Cloud Posse standards for Terraform modules

notes

@Nuru Nuru requested review from a team as code owners December 9, 2020 19:49
aknysh
aknysh reviewed Dec 9, 2020
View reviewed changes
examples/complete/main.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Dec 9, 2020
View reviewed changes
main.tf Show resolved Hide resolved
aknysh
aknysh reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

osterman
osterman reviewed Dec 9, 2020
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
osterman
osterman reviewed Dec 9, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
osterman
osterman previously approved these changes Dec 10, 2020
View reviewed changes
@Nuru Nuru requested review from osterman and aknysh December 10, 2020 06:06
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Dec 11, 2020

/test all

@Nuru
Copy link
Sponsor Contributor Author

Nuru commented Dec 12, 2020

/test all

@Nuru Nuru requested a review from a team December 13, 2020 08:51
@Nuru Nuru mentioned this pull request Dec 13, 2020
Closed
@Nuru Nuru merged commit dc860e6 into master Dec 13, 2020
@Nuru Nuru deleted the tf-14 branch December 13, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@dotCipher dotCipher Awaiting requested review from dotCipher

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nuru @osterman @aknysh