Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from the deprecated list function #28

Merged
merged 2 commits into from
Apr 16, 2021

Conversation

kjagiello
Copy link
Contributor

Now that Terraform 0.15 is released, I've run into some issues with this module as it is using a function that got removed, namely list. This PR replaces it with tolist.

Error from Terraform 0.15 for reference:

│ Error: Error in function call
│ 
│   on .terraform/modules/default_label/main.tf line 2, in locals:
│    2:   original_tags    = join(var.delimiter, compact(concat(list(var.namespace, var.stage, var.name), var.attributes)))
│     ├────────────────
│     │ var.name is a string, known only after apply
│     │ var.namespace is a string, known only after apply
│     │ var.stage is a string, known only after apply
│ 
│ Call to function "list" failed: the "list" function was deprecated in
│ Terraform v0.12 and is no longer available; use tolist([ ... ]) syntax to
│ write a literal list.

@kjagiello kjagiello requested review from a team as code owners April 15, 2021 16:18
@Gowiem
Copy link
Member

Gowiem commented Apr 16, 2021

/test all

@Gowiem
Copy link
Member

Gowiem commented Apr 16, 2021

@kjagiello any reason you're using this module over the terraform-null-label module?

@Gowiem Gowiem merged commit a0244ff into cloudposse:master Apr 16, 2021
@kjagiello
Copy link
Contributor Author

Haven't actually seen it before. Will take a look, thanks!

@Gowiem
Copy link
Member

Gowiem commented Apr 16, 2021

@kjagiello that's the main label module that I would suggest you use. This one is out of date and I believe it should be archived. I have brought that up with the rest of the Cloud Posse team, so you may see this module get archived in favor of the terraform-null-label module since that is where we're putting our effort nowadays.

@kjagiello
Copy link
Contributor Author

kjagiello commented Apr 16, 2021

I'll look into migrating away then. Thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants