fix: Make flashbar render no content when items are empty #4823
just-borisrelease.yml
on: push
Matrix: Components a11y tests
Components unit tests
6m 22s
Components integ tests
28m 12s
release
/
release
Annotations
2 errors and 14 warnings
|
useBaseComponent hook is used in all allowlisted public components › components not on the to-do list have metadata attached › flashbar: childs nodes do not have metadata property attached:
src/__tests__/use-base-component.test.tsx#L47
expect(received).toBeNull()
Received: <div class="awsui_flash_1q84n_o1lzz_153 awsui_flash-type-info_1q84n_o1lzz_914 awsui-context-flashbar" data-analytics-flashbar="info"><div class="awsui_flash-body_1q84n_o1lzz_167"><div class="awsui_flash-focus-container_1q84n_o1lzz_814" tabindex="-1"><div class="awsui_flash-icon_1q84n_o1lzz_193 awsui_flash-text_1q84n_o1lzz_844" role="img"><span class="awsui_icon_h11ix_t53c9_185 awsui_size-normal-mapped-height_h11ix_t53c9_244 awsui_size-normal_h11ix_t53c9_240 awsui_variant-normal_h11ix_t53c9_316"><svg aria-hidden="true" focusable="false" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"><circle cx="8" cy="8" r="7" /><path d="M8 12V7M8 6V4" /></svg></span></div><div class="awsui_flash-message_1q84n_o1lzz_167 awsui_flash-text_1q84n_o1lzz_844"><div class="awsui_flash-header_1q84n_o1lzz_167 awsui_flash-header_4c95g_vov7p_5" /><div class="awsui_header-replacement_1q84n_o1lzz_868 awsui_hidden_1q84n_o1lzz_863" /><div class="awsui_flash-content_1q84n_o1lzz_168 awsui_flash-header_4c95g_vov7p_5">testing</div><div class="awsui_content-replacement_1q84n_o1lzz_873 awsui_hidden_1q84n_o1lzz_863" /></div></div></div></div>
at Object.<anonymous> (src/__tests__/use-base-component.test.tsx:47:43)
|
|
Components unit tests
Process completed with exit code 1.
|
|
Components a11y tests (1)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Components a11y tests (4)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Components unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Components a11y tests (3)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Components a11y tests (6)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Components a11y tests (5)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Components a11y tests (2)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Components integ tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
RETRY 1: StickyHeader=true › should expand automatically when the cursor stops outside of the table container:
src/table/__integ__/resizable-columns.test.ts#L196
expect(received).toBeLessThan(expected)
Expected: < 1005
Received: 1005
at src/table/__integ__/resizable-columns.test.ts:196:23
at src/table/__integ__/resizable-columns.test.ts:160:7
at src/table/__integ__/resizable-columns.test.ts:148:5
at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
|
|
RETRY 2: StickyHeader=true › should expand automatically when the cursor stops outside of the table container:
src/table/__integ__/resizable-columns.test.ts#L196
expect(received).toBeLessThan(expected)
Expected: < 1005
Received: 1005
at src/table/__integ__/resizable-columns.test.ts:196:23
at src/table/__integ__/resizable-columns.test.ts:160:7
at src/table/__integ__/resizable-columns.test.ts:148:5
at Object.<anonymous> (node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13)
|
|
RETRY 1: Dropdown width › keeps not overflowing the viewport after re-rendering wider › expandToViewport: true › with autosuggest:
src/internal/components/dropdown/__integ__/width.test.ts#L150
expect(received).resolves.toContain(expected) // indexOf
Expected substring: "Loading"
Received string: "A very very very very very very very very very very very very very very very very very very very very very very very very very very long text
description1
tag1
tag2
Short text
This is a label tag"
at Object.toContain (node_modules/expect/build/index.js:174:22)
at src/internal/components/dropdown/__integ__/width.test.ts:150:63
at src/internal/components/dropdown/__integ__/width.test.ts:62:5
at node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13
|
|
RETRY 2: Dropdown width › keeps not overflowing the viewport after re-rendering wider › expandToViewport: true › with autosuggest:
src/internal/components/dropdown/__integ__/width.test.ts#L150
expect(received).resolves.toContain(expected) // indexOf
Expected substring: "Loading"
Received string: "A very very very very very very very very very very very very very very very very very very very very very very very very very very long text
description1
tag1
tag2
Short text
This is a label tag"
at Object.toContain (node_modules/expect/build/index.js:174:22)
at src/internal/components/dropdown/__integ__/width.test.ts:150:63
at src/internal/components/dropdown/__integ__/width.test.ts:62:5
at node_modules/@cloudscape-design/browser-test-tools/use-browser.js:36:13
|
|
RETRY 1: Expandable rows › uses items loader on the first expandable item:
src/table/__integ__/expandable-rows.test.ts#L69
expect(received).resolves.toBe(expected) // Object.is equality
Expected: "Loading items"
Received: ""
at Object.toBe (node_modules/expect/build/index.js:174:22)
at src/table/__integ__/expandable-rows.test.ts:69:87
at RetryOperation._fn (node_modules/p-retry/index.js:50:18)
at Timeout._onTimeout (node_modules/retry/lib/retry_operation.js:85:10)
|
|
RETRY 1: CSS Custom Properties › match previous snapshot for mode "visual-refresh":
src/__integ__/themes.test.ts#L54
expect(received).resolves.toMatchSnapshot()
Snapshot name: `CSS Custom Properties match previous snapshot for mode "visual-refresh" 1`
- Snapshot - 362
+ Received + 362
@@ -1,185 +1,185 @@
{
- "border-active-width": "4px",
- "border-code-editor-status-divider-width": "1px",
- "border-container-sticky-width": "0px",
- "border-container-top-width": "0px",
- "border-control-focus-ring-shadow-spread": "0px",
- "border-control-invalid-focus-ring-shadow-spread": "2px",
+ "border-active-width": "2px",
+ "border-code-editor-status-divider-width": "0px",
+ "border-container-sticky-width": "1px",
+ "border-container-top-width": "1px",
+ "border-control-focus-ring-shadow-spread": "1px",
+ "border-control-invalid-focus-ring-shadow-spread": "1px",
"border-divider-list-width": "1px",
"border-divider-section-width": "1px",
- "border-dropdown-virtual-offset-width": "2px",
- "border-field-width": "2px",
- "border-invalid-width": "8px",
- "border-item-width": "2px",
+ "border-dropdown-virtual-offset-width": "0px",
+ "border-field-width": "1px",
+ "border-invalid-width": "4px",
+ "border-item-width": "1px",
"border-line-chart-dash-array": "3 5",
- "border-line-chart-line-join": "round",
+ "border-line-chart-line-join": "miter",
"border-line-chart-width": "2px",
- "border-link-focus-ring-outline": "0",
- "border-link-focus-ring-shadow-spread": "2px",
- "border-panel-header-width": "1px",
- "border-panel-top-width": "1px",
- "border-radius-alert": "12px",
- "border-radius-badge": "4px",
- "border-radius-button": "20px",
- "border-radius-calendar-day-focus-ring": "3px",
- "border-radius-code-editor": "8px",
- "border-radius-container": "16px",
- "border-radius-control-circular-focus-ring": "4px",
- "border-radius-control-default-focus-ring": "4px",
- "border-radius-dropdown": "8px",
- "border-radius-dropzone": "12px",
- "border-radius-flashbar": "12px",
- "border-radius-input": "8px",
- "border-radius-item": "8px",
- "border-radius-popover": "8px",
- "border-radius-tabs-focus-ring": "20px",
- "border-radius-tiles": "8px",
- "border-radius-token": "8px",
- "border-radius-tutorial-panel-item": "8px",
- "border-table-sticky-width": "1px",
- "color-background-avatar-default": "#424650",
+ "border-link-focus-ring-outline": "5px auto Highlight",
+ "border-link-focus-ring-shadow-spread": "0px",
+ "border-panel-header-width": "0px",
+ "border-panel-top-width": "0px",
+ "border-radius-alert": "2px",
+ "border-radius-badge": "16px",
+ "border-radius-button": "2px",
+ "border-radius-calendar-day-focus-ring": "2px",
+ "border-radius-code-editor": "0px",
+ "border-radius-container": "0px",
+ "border-radius-control-circular-focus-ring": "50%",
+ "border-radius-control-default-focus-ring": "2px",
+ "border-radius-dropdown": "0px",
+ "border-radius-dropzone": "0px",
+ "border-radius-flashbar": "0px",
+ "border-radius-input": "2px",
+ "border-radius-item": "0px",
+ "border-radius-popover": "2px",
+ "border-radius-tabs-focus-ring": "0px",
+ "border-radius-tiles": "2px",
+ "border-radius-token": "2px",
+ "border-radius-tutorial-panel-item": "2px",
+ "border-table-sticky-width": "0px",
+ "color-background-avatar-default": "#545b64",
"color-background-avatar-gen-ai": "radial-gradient(circle farthest-corner at top left,rgba(0, 150, 250, 1) -25%,rgba(0, 150, 250, 0) 55%),radial-gradient(circle farthest-corner at top right, rgba(216, 178, 255, 1) -10%, rgba(115, 0, 229, 1) 50%)",
- "color-background-badge-icon": "#db0000",
- "color-background-button-link-active": "#d1f1ff",
- "color-background-button-link-hover": "#f0fbff",
- "color-background-button-normal-active": "#d1f1ff",
+ "color-background-badge-icon": "#d13212",
+ "color-background-button-link-active": "#eaeded",
+ "color-background-button-link-hover": "#fafafa",
+ "color-background-button-normal-active": "#eaeded",
"color-background-button-normal-default": "#ffffff",
"color-background-button-normal-disabled": "#ffffff",
|