Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix doctype setup for iframe dev pages #2783

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

just-boris
Copy link
Member

Description

Without this fix, the doctype inside the iframe is not set. Our components only work with html5 doctype.

Related links, issue #, if available: n/a

How has this been tested?

Locally, by checking document.doctype value

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (680ece3) to head (30a29e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2783   +/-   ##
=======================================
  Coverage   96.04%   96.04%           
=======================================
  Files         752      752           
  Lines       20979    20979           
  Branches     7147     7138    -9     
=======================================
  Hits        20149    20149           
  Misses        776      776           
  Partials       54       54           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit de33b5d Sep 27, 2024
33 checks passed
@just-boris just-boris deleted the fix-iframe-wrapper branch September 27, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants