fix: Empty notifications height #2810
Closed
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2810 +/- ##
==========================================
- Coverage 96.19% 96.18% -0.01%
==========================================
Files 761 761
Lines 21408 21411 +3
Branches 7310 6927 -383
==========================================
+ Hits 20593 20595 +2
- Misses 762 808 +46
+ Partials 53 8 -45 ☔ View full report in Codecov by Sentry. |
georgylobko
requested review from
taheramr and
just-boris
and removed request for
a team
dpitcock
reviewed
Oct 7, 2024
georgylobko
commented
Oct 7, 2024
| @@ -377,7 +379,7 @@ const AppLayoutVisualRefreshToolbar = React.forwardRef<AppLayoutProps.Ref, AppLa | |||
| {!hasToolbar && breadcrumbs ? <ScreenreaderOnly>{breadcrumbs}</ScreenreaderOnly> : null} | |||
| <SkeletonLayout | |||
| style={{ | |||
| [globalVars.stickyVerticalTopOffset]: `${verticalOffsets.header}px`, | |||
| [globalVars.stickyVerticalTopOffset]: `${verticalOffsets.header}px + ${resolvedStickyNotifications && notificationsHeight > 0 ? tokens.spaceXs : '0px'}`, | |||
There was a problem hiding this comment.
You may ask why this space is calculated here, not in the computeVerticalLayout or not just calculate it as part of notifications height.
There are 2 reasons:
- Since now notifications height includes only actual content size, not the wrapper size, we need to take this space somewhere
- It's not feasible to include this to
computeVerticalLayout, becausetokens.spaceXsis not anumber, but css token (string)
If you have a suggestion how to implement it better, let's discuss it in this thread
dpitcock
approved these changes
Oct 7, 2024
|
Temporarily addressed here #2821, closing this one for now as no urgent need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue arises when the notifications in the refresh-toolbar theme are empty. The current implementation relies on the :not(:empty) CSS property, which doesn't work because the notifications DOM node is always present, even when there are no notifications. In this PR, I updated the calculation to match how it's handled in the refresh theme
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.