Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Explose the entire token set internally #76

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Apr 23, 2024

Issue #, if available:

Description of changes:

Fixing a misalignment between SASS and JS. In SASS, we can use space-s internally, but in JS we can't.

External token files are not affected because they are handled by separate code


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (5a001b7) to head (fd1f0e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   95.61%   95.59%   -0.02%     
==========================================
  Files          47       47              
  Lines        2893     2881      -12     
  Branches      366      364       -2     
==========================================
- Hits         2766     2754      -12     
  Misses        123      123              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris marked this pull request as ready for review April 23, 2024 19:49
@just-boris just-boris requested a review from a team as a code owner April 23, 2024 19:49
@just-boris just-boris requested review from gethinwebster and removed request for a team April 23, 2024 19:49
@just-boris just-boris merged commit 6229f0e into main Apr 24, 2024
30 checks passed
@just-boris just-boris deleted the full-tokens-internal branch April 24, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants