Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to fail the build when sass deprecation warnings found #90

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

just-boris
Copy link
Member

@just-boris just-boris commented Aug 21, 2024

Issue #, if available: cloudscape-design/components#2571

Description of changes:

Detect and fail when deprecation warnings mentioned in cloudscape-design/components#2571 are found.

Made this an opt-in flag to allow gradual migration for our existing code.


I explored an alternative option about stylelint rule, but this is not possible to detect this case using stylelint, because it requires actual compliation of the sass code, to see where the issue happens


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris requested a review from a team as a code owner August 21, 2024 11:19
@just-boris just-boris requested review from cansuaa and removed request for a team August 21, 2024 11:19
"sass": "^1.49.0",
"sass": "^1.77.8",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading sass is needed, because our older version does not contain the warning

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (9590d0c) to head (33af3b5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   95.78%   95.82%   +0.04%     
==========================================
  Files          47       47              
  Lines        3016     3045      +29     
  Branches      399      408       +9     
==========================================
+ Hits         2889     2918      +29     
  Misses        123      123              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 09d2509 Aug 22, 2024
31 checks passed
@just-boris just-boris deleted the deprecation-handling branch August 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants