bug fix for quantmind#178

pulsar/utils/exceptions.py

@@ -3,6 +3,9 @@
 '''
 import traceback
 
+from .httpurl import Headers
+
+
 __all__ = ['PulsarException',
            'MonitorStarted',
            'ImproperlyConfigured',
@@ -121,13 +124,13 @@ def __init__(self, msg='', status=None, handler=None, strict=False,
         self.code = self.status  # for compatibility with HTTPError
         self.handler = handler
         self.strict = strict
-        self.headers = headers
         self.content_type = content_type
+        self._headers = Headers.make(headers)
         super().__init__(msg)
 
     @property
-    def hdrs(self):
-        return self.headers
+    def headers(self):
+        return list(self._headers)
 
 
 class HttpRedirect(HttpException):
@@ -138,17 +141,15 @@ class HttpRedirect(HttpException):
     status = 302
 
     def __init__(self, location, status=None, headers=None, **kw):
-        headers = [] if headers is None else headers
-        headers.append(('location', location))
+        headers = Headers.make(headers)
+        headers['location'] = location
         super().__init__(status=status or self.status, headers=headers, **kw)
 
     @property
     def location(self):
         '''The value in the ``Location`` header entry.
-
-        Equivalent to ``self.headers['location']``.
         '''
-        return self.headers['location']
+        return self._headers['location']
 
 
 class BadRequest(HttpException):

pulsar/utils/httpurl.py

@@ -477,7 +477,7 @@ def parse_options_header(header, options=None):
     return ctype, options
 
 
-class Headers(object):
+class Headers:
     '''Utility for managing HTTP headers for both clients and servers.
 
     It has a dictionary like interface with few extra functions to facilitate
@@ -511,6 +511,12 @@ class Headers(object):
     The strict parameter is rarely used and it forces the omission on
     non-standard header fields.
     '''
+    @classmethod
+    def make(cls, headers):
+        if not isinstance(headers, cls):
+            headers = cls(headers=headers)
+        return headers
+
     def __init__(self, headers=None, kind='server', strict=False):
         if isinstance(kind, int):
             kind = header_type.get(kind, 'both')

release/notes.md

@@ -0,0 +1 @@
+* Bug fix in ``HttpRedirect.location`` attribute

release/release.json

@@ -0,0 +1,4 @@
+{
+    "tag_name": "1.0.6",
+    "name": ""
+}

tests/wsgi/errors.py

@@ -0,0 +1,14 @@
+import unittest
+
+from pulsar import HttpRedirect
+
+
+class WsgiRequestTests(unittest.TestCase):
+
+    def test_httpredirect(self):
+        location = 'https://pythonhosted.org/pulsar'
+        r = HttpRedirect(location)
+        self.assertEqual(r.location, location)
+        r = HttpRedirect(location, headers=[('Content-Type', 'text/html')])
+        self.assertEqual(len(r.headers), 2)
+        self.assertEqual(r.location, location)