Pass source for history actions (slab#3514)

* Pass source for history actions Since undo, redo emitted by user the source should USER. * Add tests for history.undo()/redo() --------- Co-authored-by: Zihua Li <i@zihua.li>
cmrd-senya · Aug 7, 2023 · e2113db · e2113db
1 parent 042c8ef
commit e2113db
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/modules/history.ts b/modules/history.ts
@@ -74,7 +74,7 @@ class History extends Module<HistoryOptions> {
     this.quill.updateContents(delta, Quill.sources.USER);
     this.ignoreChange = false;
     const index = getLastChangeIndex(this.quill.scroll, delta);
-    this.quill.setSelection(index);
+    this.quill.setSelection(index, Quill.sources.USER);
   }
 
   clear() {

diff --git a/test/unit/modules/history.js b/test/unit/modules/history.js
@@ -81,6 +81,20 @@ describe('History', function () {
       expect(quill.history.stack.undo.length).toEqual(2);
     });
 
+    it('emits selection changes', function () {
+      const quill = new Quill(this.container.firstChild, {
+        modules: {
+          history: { delay: 0 },
+        },
+      });
+      quill.insertText(0, 'foo');
+      const change = jasmine.createSpy('change');
+      quill.on('selection-change', change);
+      quill.history.undo();
+
+      expect(change).toHaveBeenCalledOnceWith(jasmine.anything(), null, 'user');
+    });
+
     it('user change', function () {
       this.quill.root.firstChild.innerHTML = 'The lazy foxes';
       this.quill.update();