-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMSSW Integration of LST #45117
base: master
Are you sure you want to change the base?
CMSSW Integration of LST #45117
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45117/40456
|
A new Pull Request was created by @VourMa for master. It involves the following packages:
The following packages do not have a category, yet: RecoTracker/LST @cmsbuild, @rappoccio, @jfernan2, @davidlange6, @mandrenguyen, @fabiocos, @antoniovilela can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
@cmsbuild please test |
-1 Failed Tests: UnitTests Unit TestsI found 2 errors in the following unit tests: ---> test TestDQMOnlineClient-hlt_dqm_sourceclient had ERRORS ---> test testTrackingResolution had ERRORS Comparison SummarySummary:
|
both are apparently related to LST |
it's not obvious how this dependency comes about from looking at https://github.com/cms-sw/cmssw/blob/master/DQM/TrackingMonitorSource/test/testTrackResolution_cfg.py (a @makortel |
assign heterogeneous |
LLVM was updated from 17 to 18 that resulted in some changes in the formatting.
CMSSW_14_2_0_pre1 |
Yes, see #45870 . |
If you can figure out how to get back the old behaviour with LLVM 18, maybe we could revert the change ? |
+1 Size: This PR adds an extra 476KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
batch 6 was merged now with the following updates: 9713499bugfixes to incomplete alpaka::wait cleanup:
f245be0More comments from the PR review; it resolves:
d2b9e89
@VourMa will resolve the addressed comments some time soon (only a PR submitter can, apaprently) |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45117/41807
|
Pull request #45117 was updated. @AdrianoDee, @antoniovilela, @cmsbuild, @consuegs, @davidlange6, @fabiocos, @fwyzard, @jfernan2, @kskovpen, @makortel, @mandrenguyen, @miquork, @perrotta, @rappoccio, @saumyaphor4252, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again. |
@cmsbuild please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
This PR integrates the LST algorithm in CMSSW. A summary of the algorithm and its scope can be found in the recent LST presentation at the Phase 2 Software days (April 2024).
The PR includes the following additions/modifications:
The interface exposed to CMSSW.
The actual LST code.
Scripts to be used for compiling, using & testing LST outside of the full CMSSW framework.
⇒ Not relevant for CMSSW review.
⇒ Preserve ability to run in standalone.
The input & output data formats for LST.
The producers:
The configuration files needed for running LST.
Class definitions and ES producer supporting files.
test:→ Dropped in favor of a proper workflow.Scripts for local testing
Runs only the first two iterations of tracking (initialStep & highPtTripletStep).
Useful for comparisons, as LST (for now) replaces only those two tracking iterations.
Runs the LST algorithm instead of KalmanFilter for track building/seeding.
The existence of the gpu process modifier defines the hardware the algorithm runs on (CPU or GPU).There is a single change not strictly related to the above categories and a dedicated comment will be made on it.
In general, we prefer to have minimal or at most header-only dependency of LSTCore on other CMSSW packages to preserve the ability to run with standalone scripts.
This is a large PR, so we start it as an RFC with the main batch of files. In the next days, the following updates are to be expected, so that the PR can be merged:
(bot tests will probably not work currently).Goes together with cms-data/RecoTracker-LSTCore#1 (now merged).
@slava77 @ariostas
List of unresolved comments (to be updated in batches - last update: 2024/08/19):
SegmentLinking#75