Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VISUALIZATION] Changes suggested by new llvm18 clang-format #45898

Merged

Conversation

smuzaffar
Copy link
Contributor

This PR applies clang-format changes suggested by new llvm18 ( see #45870 )

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • Fireworks/Calo (visualization)
  • Fireworks/Core (visualization)
  • Fireworks/FWInterface (visualization)
  • Fireworks/Tracks (visualization)

@Dr15Jones, @alja, @cmsbuild, @makortel can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@alja
Copy link
Contributor

alja commented Sep 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e002b0/41347/summary.html
COMMIT: de16ab8
CMSSW: CMSSW_14_2_X_2024-09-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45898/41347/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c8bbbfa into cms-sw:master Sep 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants