French translation and update in translation files #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to open this draft PR to propose the idea. I did all the translation and added fr in supported languages in shape_logic.py, which seems to be all that is required to add a new translation (comparing with es and de).
That being said I saw that you had documentation on how to update translation, so maybe you don't want me to do it this way and use the other. Unfortunately, the other use your private repo.
Which brings me to my next point. How could I access or be a member of that private repo. I know it's possible as other CMU student have access to it. I am just proposing as I think I can become a valuable asset to the team.
Thanks