Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent naming convention #12

Open
basilkohler opened this issue Oct 29, 2014 · 2 comments
Open

inconsistent naming convention #12

basilkohler opened this issue Oct 29, 2014 · 2 comments

Comments

@basilkohler
Copy link
Contributor

example: pkt-ccntlv-enc.c: ccnl_ccntlv_fillContentWithHdr instead of ccnl_ccntlv_fill_content_with_hdr

what should the convention be? Always a_b?

@tschudin
Copy link
Contributor

On Wed, 29 Oct 2014, Basil Kohler wrote:

example: pkt-ccntlv-enc.c: ccnl_ccntlv_fillContentWithHdr instead of
ccnl_ccntlv_fill_content_with_hdr

what should the convention be? Always a_b?

No, I prefer camelcase for the functional desciption and x_y for the
categories (ccnl software, ccntlv library)

@basilkohler
Copy link
Contributor Author

In that case there there are other incosistent names like ccnl_get_face_or_create or ccnl_populate_cache.

This is a minor issue ofcourse and i would give it a low priority if possible with the github interface.
But it is probably a good idea to make the naming consistent going forward and maybe write the naming convention down somewhere so that everyone is aware of them.

@blacksheeep blacksheeep added this to the Code Styling Guide milestone Feb 2, 2018
@blacksheeep blacksheeep removed this from the Code Styling Guide milestone Feb 2, 2018
PeterKietzmann pushed a commit to PeterKietzmann/ccn-lite that referenced this issue Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants