Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cis tlv from ccn-lite #228

Merged
merged 1 commit into from
Apr 7, 2018
Merged

remove cis tlv from ccn-lite #228

merged 1 commit into from
Apr 7, 2018

Conversation

mfrey
Copy link
Collaborator

@mfrey mfrey commented Apr 5, 2018 •
edited
Loading

Like #222 this PR removes cis tlv from ccn-lite. This PR adresses issue #213. Feature regression is based on a git grep on cis, USE_SUITE_CISTLV, and CCNL_SUITE_CISTLV.

If the PR gets approved, the commits need to be squashed before a merge.

@mfrey mfrey added regression feature regression requires squashing commits need to be squashed before merge labels Apr 5, 2018
@mfrey mfrey changed the title removes cis tlv from ccn-lite remove cis tlv from ccn-lite Apr 5, 2018
cgundogan
cgundogan previously approved these changes Apr 6, 2018
View reviewed changes
Copy link
Collaborator

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. How about your opinion @blacksheeep ?

blacksheeep
blacksheeep previously approved these changes Apr 6, 2018
View reviewed changes
Copy link
Contributor

@blacksheeep blacksheeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test scripts prove that the implementation is not broken.
ACK

@cgundogan
Copy link
Collaborator

@mfrey please squash

@mfrey mfrey dismissed stale reviews from blacksheeep and cgundogan via 05b4ed7 April 7, 2018 12:50
@mfrey mfrey removed the requires squashing commits need to be squashed before merge label Apr 7, 2018
@blacksheeep blacksheeep self-requested a review April 7, 2018 12:56
blacksheeep
blacksheeep approved these changes Apr 7, 2018
View reviewed changes
Copy link
Contributor

@blacksheeep blacksheeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@blacksheeep blacksheeep merged commit c5486fe into cn-uofbasel:master Apr 7, 2018
@mfrey mfrey deleted the rm-cistlv branch April 8, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacksheeep blacksheeep blacksheeep approved these changes

@cgundogan cgundogan cgundogan left review comments

Assignees
No one assigned
Labels
regression feature regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfrey @cgundogan @blacksheeep