addressed 'NULL' issue in ccnl_i_prefixof_c #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacksheeep
previously approved these changes
Aug 2, 2018
cgundogan
reviewed
Aug 2, 2018
src/ccnl-core/include/ccnl-prefix.h
Outdated
| * @return 0 if full match | ||
| * @return n>0 for matched components | ||
| */ | ||
| int | ||
| ccnl_i_prefixof_c(struct ccnl_prefix_s *prefix, | ||
| int ccnl_i_prefixof_c(struct ccnl_prefix_s *prefix, |
There was a problem hiding this comment.
I am wondering about this re-alignement here. All other signatures start with the return type and the function name in the below line.
There was a problem hiding this comment.
We probably should start to talk about a style guide soon.
mfrey
force-pushed
the
ccnl_i_prefixof_c-fix
branch
from
4b35a1c
to
cc66c64
Compare
cgundogan
reviewed
Aug 2, 2018
src/ccnl-core/include/ccnl-prefix.h
Outdated
| * @return 0 if full match | ||
| * @return n>0 for matched components | ||
| */ | ||
| int | ||
| int |
There was a problem hiding this comment.
why is here an extra whitespace?
mfrey
force-pushed
the
ccnl_i_prefixof_c-fix
branch
from
cc66c64
to
1401c21
Compare
mfrey
force-pushed
the
ccnl_i_prefixof_c-fix
branch
from
1401c21
to
2500074
Compare
cgundogan
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This issue was identified by clangs static analyzer ("argument with 'nonnull' attribute passed null"). If the check in
would fail, the subsequent call to
might also fail (i.e.
mdisNULL).