fixes potential memory leak in ccn-lite-ctrl.c #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrey
changed the title
cgundogan
reviewed
Jan 31, 2019
src/ccnl-utils/src/ccn-lite-ctrl.c
Outdated
| port = strtol(strtok(NULL, "/"), NULL, 0); | ||
| use_udp = 1; | ||
| printf("udp: <%s> <%i>\n", udp, port); | ||
|
|
||
| /** if memory has been allocated previously, free it */ | ||
| if (udp_temp) { |
There was a problem hiding this comment.
Isn't udp_temp always non-NULL here? Is this check necessary?
There was a problem hiding this comment.
If Malloc returns NULL in strdup because system is out of memory it can be NULL
There was a problem hiding this comment.
But there is a check for that only 9 lines above ..
There was a problem hiding this comment.
Right. Missed that. So, we can remove that.
blacksheeep
approved these changes
Jan 31, 2019
blacksheeep
requested changes
Jan 31, 2019
mfrey
force-pushed
the
ccn-lite-ctrl_memory-fix
branch
from
b886400
to
f31818b
Compare
Has been addressed with the latest updated commit (rebased, push -f) @blacksheeep Could you please approve the PR? |
cgundogan
approved these changes
Jan 31, 2019
blacksheeep
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The PR checks if a call to
strdupfailed and also introduces a new variable which stores the newly allocated memory before it is overwritten again by a call tostrtokand thus, the memory allocated bystrdupcan't be freed anymore.Issues/PRs references
Fixes #327