matchers: add range matchers #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdroth
reviewed
Jan 13, 2022
xds/type/matcher/v3/range.proto
Outdated
| int64 end = 2; | ||
| } | ||
|
|
||
| // Specifies a set of ranges for matching an int64 number. |
There was a problem hiding this comment.
Are these sublinear matchers or linear matchers? If sublinear, what are the precedence rules when there are multiple matching ranges? Please document.
There was a problem hiding this comment.
First one wins. Thanks. Yes, this is intended to be implemented with a segment tree or the likes.
|
Gentle ping. |
markdroth
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com