Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #327: OCI Registry for use with path-based-routing #313

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Fixes #327: OCI Registry for use with path-based-routing #313

merged 2 commits into from
Sep 16, 2024

Conversation

jessesanford
Copy link
Contributor

@jessesanford jessesanford commented Jun 19, 2024 •
edited
Loading

Fixes #327 by setting up nginx rewrite rules on the ingress so that the generic OCI registry discovery urls can be found when using path based routing.

@jessesanford jessesanford added the enhancement New feature or request label Jun 19, 2024
@jessesanford jessesanford requested review from nimakaviani, nabuskey and a team June 19, 2024 05:43
@jessesanford
Copy link
Contributor Author

@csantanapr 🍻

@cmoulliard
Copy link
Contributor

Can you add a description to this PR plus an issue as this is not clear for the reviewers to figure out what is the purpose of this PR ?

Remark: PR should be rejected if they don't include an issue's link and/or description

@jessesanford
Copy link
Contributor Author

Can you add a description to this PR plus an issue as this is not clear for the reviewers to figure out what is the purpose of this PR ?

Remark: PR should be rejected if they don't include an issue's link and/or description

I agree, this is intentionally a quick draft PR to help with a need that @csantanapr had. I will create an issue and appropriate documentation before submitting the actual PR.

@jessesanford
Fixes cnoe-io#327 OCI Registry working with path-base-routing
d101929 
Signed-off-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>
@jessesanford jessesanford changed the title working login, push and pull from workstation w/ use-path-routing=true Fix OCI Registry for use with path-based-routing Sep 13, 2024
@jessesanford
use larger proxy-body-size
17ff7c2 
Signed-off-by: Jesse Sanford <108698+jessesanford@users.noreply.github.com>
@jessesanford jessesanford changed the title Fix OCI Registry for use with path-based-routing Fixes #327: OCI Registry for use with path-based-routing Sep 14, 2024
@jessesanford jessesanford marked this pull request as ready for review September 14, 2024 04:19
@cmoulliard
Copy link
Contributor

I will create an issue and appropriate documentation before submitting the actual PR.

Don't forget please to add the ticket and description

@jessesanford jessesanford merged commit 5c47cf7 into cnoe-io:main Sep 16, 2024
7 checks passed
@nabuskey nabuskey mentioned this pull request Oct 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeromano blakeromano blakeromano approved these changes

@nimakaviani nimakaviani Awaiting requested review from nimakaviani

@nabuskey nabuskey Awaiting requested review from nabuskey

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: OCI Registry with path based routing
4 participants
@jessesanford @cmoulliard @nabuskey @blakeromano