Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable syntax highlighting by default on all platforms #180

Closed
johannhof opened this issue Jan 14, 2017 · 13 comments
Closed

Enable syntax highlighting by default on all platforms #180

johannhof opened this issue Jan 14, 2017 · 13 comments
Assignees
Labels
enhancement Improve the expected
Milestone

Comments

@johannhof
Copy link
Contributor

This requires either forking or patching syntect to pass the static-libonig flag to rust-onig, AFAIU.

@johannhof johannhof added this to the 0.6 milestone Jan 14, 2017
@johannhof johannhof self-assigned this Jan 14, 2017
@epage epage added the enhancement Improve the expected label May 5, 2017
@Geobert
Copy link
Contributor

Geobert commented Jan 1, 2018

I've seen this for Windows compilation issue: rust-onig/rust-onig#35
EDIT: unfortunately, with call "%VS140COMNTOOLS%\..\..\VC\vcvarsall.bat"
plist doesn't compile any more:

error: linking with `link.exe` failed: exit code: 1112
  |
  = note: "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\link.exe" "/NOLOGO" "/NXCOMPAT" "/LIBPATH:C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "I:\\Dev\\cobalt.rs\\target\\debug\\build\\plist-d2fcde2dbdd7a78c\\build_script_build-d2fcde2dbdd7a78c.build_script_build0.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\build\\plist-d2fcde2dbdd7a78c\\build_script_build-d2fcde2dbdd7a78c.build_script_build1.rust-cgu.o" "/OUT:I:\\Dev\\cobalt.rs\\target\\debug\\build\\plist-d2fcde2dbdd7a78c\\build_script_build-d2fcde2dbdd7a78c.exe" "I:\\Dev\\cobalt.rs\\target\\debug\\build\\plist-d2fcde2dbdd7a78c\\build_script_build-d2fcde2dbdd7a78c.crate.allocator.rust-cgu.o" "/OPT:REF,NOICF" "/DEBUG" "/NATVIS:C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libcore.natvis" "/LIBPATH:I:\\Dev\\cobalt.rs\\target\\debug\\deps" "/LIBPATH:C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-571928b9eba253d1.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc_system-b4bd41caf6074e96.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librand-41112daf4169c38d.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-53d49172c207c98c.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liblibc-ee44bdc6692fd9c9.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-ede05b6f46264373.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd_unicode-0639d4cde67a9493.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-78df137af729c1d4.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-e07db25254090156.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-a3d4cc1d8f3f719c.rlib" "advapi32.lib" "ws2_32.lib" "userenv.lib" "shell32.lib" "msvcrt.lib"
  = note: msvcrt.lib(chkstk.obj) : fatal error LNK1112: module machine type 'X86' conflicts with target machine type 'x64'


error: aborting due to previous error

error: Could not compile `plist`.
warning: build failed, waiting for other jobs to finish...
error: build failed

@epage
Copy link
Member

epage commented Jan 1, 2018

So it sounds like, as of last March, this should now be possible? Great! That should be a straightforward PR to implement. I think I've already removed the platform conditionals, relying only on the feature flag.

So my guess as to whats left

  • Mirroring the test builds between the two platforms
  • Ensuring our pre-built binaries on both platforms includes syntax highlighting

@Geobert
Copy link
Contributor

Geobert commented Jan 1, 2018

I know it's possible because Gutenberg has it build on appveyor. But I tried to build Gutenberg and I have the onig_sys issue. I'm trying to build with the gnu version of the toolchain, I'll keep you posted :)

@Geobert
Copy link
Contributor

Geobert commented Jan 1, 2018

with MSVC toolchain:

error: failed to run custom build command for `onig_sys v65.0.1`
process didn't exit successfully: `I:\Dev\cobalt.rs\target\debug\build\onig_sys-45613c6560956e7f\build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'Build error:
STDERR:'nmake' is not recognized as an internal or external command,
operable program or batch file.

STDOUT:
C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\onig_sys-65.0.1\oniguruma>cd src

C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\onig_sys-65.0.1\oniguruma\src>copy config.h.win64 config.h
        1 file(s) copied.

C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\onig_sys-65.0.1\oniguruma\src>nmake -f Makefile.windows
', C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\onig_sys-65.0.1\build.rs:59:8
note: Run with `RUST_BACKTRACE=1` for a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

with GNU toolchain:

error: failed to run custom build command for `miniz-sys v0.1.10`
process didn't exit successfully: `I:\Dev\cobalt.rs\target\debug\build\miniz-sys-61b50e9db6261f96\build-script-build` (exit code: 101)
--- stdout
TARGET = Some("x86_64-pc-windows-gnu")
OPT_LEVEL = Some("0")
TARGET = Some("x86_64-pc-windows-gnu")
HOST = Some("x86_64-pc-windows-gnu")
TARGET = Some("x86_64-pc-windows-gnu")
TARGET = Some("x86_64-pc-windows-gnu")
HOST = Some("x86_64-pc-windows-gnu")
CC_x86_64-pc-windows-gnu = None
CC_x86_64_pc_windows_gnu = None
HOST_CC = None
CC = None
TARGET = Some("x86_64-pc-windows-gnu")
HOST = Some("x86_64-pc-windows-gnu")
CFLAGS_x86_64-pc-windows-gnu = None
CFLAGS_x86_64_pc_windows_gnu = None
HOST_CFLAGS = None
CFLAGS = None
DEBUG = Some("true")
running: "gcc.exe" "-O0" "-ffunction-sections" "-fdata-sections" "-g" "-m64" "-Wall" "-Wextra" "-o" "I:\\Dev\\cobalt.rs\\target\\debug\\build\\miniz-sys-f1ec056bb91ce631\\out\\miniz.o" "-c" "miniz.c"

--- stderr
thread 'main' panicked at '

Internal error occurred: Failed to find tool. Is `gcc.exe` installed? (see https://github.com/alexcrichton/cc-rs#compile-time-requirements for help)

', C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\cc-1.0.3\src\lib.rs:1874:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.

warning: build failed, waiting for other jobs to finish...
error: build failed

@epage
Copy link
Member

epage commented Jan 1, 2018

Can you build the sass feature of cobalt? Both errors look like general install problems preventing the building of -sys packages.

@Geobert
Copy link
Contributor

Geobert commented Jan 1, 2018

Didn't work :(

λ cargo build --features="sass"
   Compiling gcc v0.3.54
   Compiling sass-sys v0.4.1
error: failed to run custom build command for `sass-sys v0.4.1`
process didn't exit successfully: `I:\Dev\cobalt.rs\target\debug\build\sass-sys-5467e038dcdba889\build-script-build` (exit code: 101)
--- stderr
fatal: Not a git repository (or any of the parent directories): .git
thread 'main' panicked at 'Build error:
STDERR:
STDOUT:Microsoft (R) Build Engine version 14.0.25420.1
Copyright (C) Microsoft Corporation. All rights reserved.

Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
Build started 01/01/2018 19:26:16.
Project "C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.sln" on node 1 (default targets).
ValidateSolutionConfiguration:
  Building solution configuration "Release|Win64".
Project "C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.sln" (1) is building "C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj" (2) on node 1 (default targets).
GitVersion:
  git -C .. describe --abbrev=4 --dirty --always --tags
C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj(10,5): warning : fatal: Not a git repository (or any of the parent directories): .git
  The previous error was converted to a warning because the task was called with ContinueOnError=true.
C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj(10,5): warning MSB3073: The command "git -C .. describe --abbrev=4 --dirty --always --tags" exited with code 128.
  The previous error was converted to a warning because the task was called with ContinueOnError=true.
  Build continuing because "ContinueOnError" on the task "Exec" is set to "true".
Main:
  libsass:
  Building Static LibSass
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\x64\PlatformToolsets\v140\Toolset.targets(36,5): error MSB8036: The Windows SDK version 8.1 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj]
Done Building Project "C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj" (default targets) -- FAILED. Done Building Project "C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.sln" (default targets) -- FAILED.

Build FAILED.

"C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.sln" (default target) (1) ->
"C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj" (default target) (2) ->
(GitVersion target) ->
  C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj(10,5): warning : fatal: Not a git repository (or any of the parent directories): .git
  C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj(10,5): warning MSB3073: The command "git -C .. describe --abbrev=4 --dirty --always --tags" exited with code 128.


"C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.sln" (default target) (1) ->
"C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj" (default target) (2) ->
(Desktop_PlatformPrepareForBuild target) ->
  C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\x64\PlatformToolsets\v140\Toolset.targets(36,5): error MSB8036: The Windows SDK version 8.1 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\libsass\win\libsass.vcxproj]

    2 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.31
', C:\Users\Geob\.cargo\registry\src\github.com-1ecc6299db9ec823\sass-sys-0.4.1\build.rs:66:8
note: Run with `RUST_BACKTRACE=1` for a backtrace.

@Geobert
Copy link
Contributor

Geobert commented Jan 1, 2018

@Geobert
Copy link
Contributor

Geobert commented Jan 1, 2018

Ok! I was able to compile with sass after installing https://developer.microsoft.com/en-us/windows/downloads/windows-8-1-sdk

for syntect, I'm missing nmake, investigation ongoing :)

@epage
Copy link
Member

epage commented Jan 1, 2018

I've created cobalt-org/cobalt-org.github.io#19 to track adding these requirements to the website

@Geobert
Copy link
Contributor

Geobert commented Jan 2, 2018

after adding C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\ to my PATH onig_sys compiled and I have Rust compilation error now, big progress!

error[E0432]: unresolved import `syntect`
  --> src\syntax_highlight\syntect.rs:11:5
   |
11 | use syntect::parsing::{SyntaxDefinition, SyntaxSet};
   |     ^^^^^^^ Did you mean `syntax_highlight::syntect`?

error[E0432]: unresolved import `syntect`
  --> src\syntax_highlight\syntect.rs:12:5
   |
12 | use syntect::highlighting::{ThemeSet, Theme};
   |     ^^^^^^^ Did you mean `syntax_highlight::syntect`?

error[E0432]: unresolved import `syntect`
  --> src\syntax_highlight\syntect.rs:13:5
   |
13 | use syntect::html::{IncludeBackground, highlighted_snippet_for_string, styles_to_coloured_html,
   |     ^^^^^^^ Did you mean `syntax_highlight::syntect`?

error[E0432]: unresolved import `syntect`
  --> src\syntax_highlight\syntect.rs:15:5
   |
15 | use syntect::easy::HighlightLines;
   |     ^^^^^^^ Did you mean `syntax_highlight::syntect`?

error[E0606]: casting `usize` as `*const syntax_highlight::syntect::Setup` is invalid
  --> src\syntax_highlight\syntect.rs:30:1
   |
30 | / lazy_static!{
31 | |     static ref SETUP: Setup = Setup {
32 | |         syntax_set: SyntaxSet::load_defaults_newlines(),
33 | |         theme_set: ThemeSet::load_defaults()
34 | |     };
35 | | }
   | |_^
   |
   = note: this error originates in a macro outside of the current crate

error: aborting due to 5 previous errors

error: Could not compile `cobalt-bin`.

To learn more, run the command again with --verbose.

@Geobert
Copy link
Contributor

Geobert commented Jan 2, 2018

Ok it was because of not(windows) now it compiles fine but linking is failing:

Compiling cobalt-bin v0.9.0 (file:///I:/Dev/cobalt.rs)
error: linking with `link.exe` failed: exit code: 1120
  |
  = note: "C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\bin\\amd64\\link.exe" "/NOLOGO" "/NXCOMPAT" "/LIBPATH:C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt0.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt1.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt10.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt11.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt12.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt13.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt14.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt15.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt2.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt3.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt4.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt5.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt6.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt7.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt8.rust-cgu.o" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.cobalt9.rust-cgu.o" "/OUT:I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.exe" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\cobalt-d5c45d3d9cdfd6ab.crate.allocator.rust-cgu.o" "/OPT:REF,NOICF" "/DEBUG" "/NATVIS:C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\liballoc.natvis" "/NATVIS:C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\etc\\libcore.natvis" "/LIBPATH:I:\\Dev\\cobalt.rs\\target\\debug\\deps" "/LIBPATH:I:\\Dev\\cobalt.rs\\target\\debug\\build\\miniz-sys-f03a6f9f45c3337c\\out" "/LIBPATH:C:\\Users\\Geob\\.cargo\\registry\\src\\github.com-1ecc6299db9ec823\\onig_sys-65.0.1\\oniguruma\\src" "/LIBPATH:C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libhyper-0dae58b6033832ac.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libtypeable-b2c20135c920b9c6.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libcobalt-bfa029e9c9244d4c.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libnormalize_line_endings-dd84e507355d0eeb.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libjsonfeed-ea0314662113a95b.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libclap-a749def2083a92e9.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libansi_term-1e7f357aaf2a4b7a.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libvec_map-cd4b53a6058c2daa.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libtraitobject-72a9eb2221ec607e.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libserde_yaml-dbd6fc44ad647f45.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libyaml_rust-f63fcde820414fad.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\liblinked_hash_map-53964a192bab8adf.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libghp-269a9efa65900fab.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libwalkdir-0e95ea10dbc72cca.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libnum_cpus-a710a0fff9232280.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\librss-99ea2c44347b7fef.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libquick_xml-ad7bc87bf3112bd8.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libencoding_rs-f5e195e12ddf41c2.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libtextwrap-aee07f4b61ee6c02.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libunicode_width-fb0ebe0780e52718.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libhttparse-72d4b071f25c257f.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libsyntect-f277cbf1a0af8e1e.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libflate2-9b188b9b3cb35be3.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libminiz_sys-43dca649363f0a2b.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libwalkdir-4cdbebb339828b6f.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libonig-c2f134a00652abbf.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libonig_sys-b2bdad94a1af1f99.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libplist-8e23865feacc0225.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libxml-638d98bec350efa2.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libbase64-ce628f86297940ce.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libbincode-8dc1b9d661a4c332.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libignore-f6cc2e02df9d8c38.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libglobset-4e37449d5e9fdc6a.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libmemchr-7549d9e971384fc1.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libcrossbeam-2e45fe3a83caacbc.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libstrsim-ab7fe016fcab9d5e.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libfnv-241e4f9f6c939b0d.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libnotify-9ac736a1d4056be1.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libfiletime-7fea811b3efa83ef.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libbitflags-1a7c5de763537487.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libunicase-1ff8acb492b8eed5.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libliquid-db9f0dd84defc17e.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\liburl-3e4f386500c6a842.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libpercent_encoding-a7303d2b26a6a05b.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libitertools-c65ba7daf5dc09ed.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libeither-29716444230699c3.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libunicode_segmentation-684c21f58a7b9047.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libchrono-17eca13cba1f588f.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libnum-f34d554fa70c4ae6.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libmime-e0db6f68508e1c55.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libidna-a537bc95d925c3af.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libunicode_normalization-cfabc60f893965eb.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libunicode_bidi-595849a569cac173.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libpulldown_cmark-ee697b0cbe2219a5.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libbitflags-9f07ef9fd9ab553b.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\liberror_chain-a2ae3d2b1795deca.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libserde_json-aec555cd8d197ba7.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libdtoa-681851b505cc13ac.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libitoa-a715ee0fb862295e.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libtoml-931f79d3df4491ca.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libserde-2d50e1433b52aad1.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libsame_file-48b05856e8334982.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libtime-bd6d87baeb2bf34b.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libbitflags-98846b8f7a951989.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libnum_iter-ccace857d206c53f.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libnum_integer-27b84861d2a97188.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libnum_traits-d00c0d965636938f.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libatty-962c17b3d812b941.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libenv_logger-9e6ef38706c7c0ea.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libregex-e46b94521c4e87fe.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libutf8_ranges-8de659d4dcab5f08.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libregex_syntax-907928754db4eb59.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libthread_local-3f97f41e2063c204.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\liblazy_static-f1718b3adf391196.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libaho_corasick-93041034a0ec0255.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libmemchr-15272ebf0499ff46.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\liblibc-95790fdf6ab6ff56.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\liblog-4d48161b115012e4.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libunreachable-55af80f97d5e541f.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libvoid-bf2eeee597d19845.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libbase64-7ed94a9d8ca44290.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libsafemem-e0e7d33c651a42b9.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libbyteorder-c8e4ea272d31f0e6.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libwalkdir-0827fb4f1c73597b.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libsame_file-c6ce74fa0b20ba7b.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\liblanguage_tags-b8da7186a21ae683.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libmatches-39e58e560ca3ab9a.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\liberror_chain-e6b9b9fdd7a0e803.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libbacktrace-4a70d4293ab46d39.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\librustc_demangle-6ff291c8a79157c5.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libcfg_if-694c208a1b3ac340.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libdbghelp-67d2b9b0b35aad80.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libkernel32-dc7755af0cb2f4c1.rlib" "I:\\Dev\\cobalt.rs\\target\\debug\\deps\\libwinapi-40eba117914c673c.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd-571928b9eba253d1.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libpanic_unwind-53d49172c207c98c.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libunwind-78df137af729c1d4.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liblibc-ee44bdc6692fd9c9.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc_system-b4bd41caf6074e96.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\liballoc-ede05b6f46264373.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libstd_unicode-0639d4cde67a9493.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\librand-41112daf4169c38d.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcore-e07db25254090156.rlib" "C:\\Users\\Geob\\.rustup\\toolchains\\stable-x86_64-pc-windows-msvc\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-a3d4cc1d8f3f719c.rlib" "kernel32.lib" "ws2_32.lib" "userenv.lib" "dbghelp.lib" "kernel32.lib" "advapi32.lib" "ws2_32.lib" "userenv.lib" "shell32.lib" "msvcrt.lib"
  = note: libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig1.rust-cgu.o) : error LNK2019: unresolved external symbol onig_region_copy referenced in function _ZN4onig6region6Region14clone_from_raw17h086233679ee06bc2E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig1.rust-cgu.o) : error LNK2019: unresolved external symbol onig_region_clear referenced in function _ZN4onig6region6Region5clear17hb8549527c30356d9E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig1.rust-cgu.o) : error LNK2019: unresolved external symbol onig_region_resize referenced in function _ZN4onig6region6Region7reserve17h79490660caab5bb0E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig1.rust-cgu.o) : error LNK2019: unresolved external symbol onig_get_capture_tree referenced in function _ZN4onig6region6Region4tree17h1ea5c161f820632bE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig1.rust-cgu.o) : error LNK2019: unresolved external symbol onig_region_free referenced in function _ZN62_$LT$onig..region..Region$u20$as$u20$core..ops..drop..Drop$GT$4drop17h1ff5f854a4b08c75E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_number_of_names referenced in function _ZN4onig5names29_$LT$impl$u20$onig..Regex$GT$17capture_names_len17h5f1b0a9689f9caafE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_error_code_to_str referenced in function _ZN4onig5Error3new17h0da3de302a40868aE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_new referenced in function _ZN4onig5Regex25with_options_and_encoding17h8496553ee9391467E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_match referenced in function _ZN4onig5Regex19match_with_encoding17h19466155dd2702b8E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_search referenced in function _ZN4onig5Regex20search_with_encoding17h25b7349350caca7dE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_get_encoding referenced in function _ZN4onig5Regex8encoding17h59bb174b84030a00E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_number_of_captures referenced in function _ZN4onig5Regex12captures_len17hf170ce73fbc2d832E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_number_of_capture_histories referenced in function _ZN4onig5Regex21capture_histories_len17h03b5ad9638438e55E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig2.rust-cgu.o) : error LNK2019: unresolved external symbol onig_free referenced in function _ZN53_$LT$onig..Regex$u20$as$u20$core..ops..drop..Drop$GT$4drop17h9e04f41d20735620E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxASIS referenced in function _ZN4onig6syntax6Syntax4asis17h1e24b6d6f0595c0aE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxPosixBasic referenced in function _ZN4onig6syntax6Syntax11posix_basic17hc9f542c56e9c6d4cE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxPosixExtended referenced in function _ZN4onig6syntax6Syntax14posix_extended17hc743a3eede50ca37E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxEmacs referenced in function _ZN4onig6syntax6Syntax5emacs17hebbf2976bb7b569cE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxGrep referenced in function _ZN4onig6syntax6Syntax4grep17h5f03d3a60a5e3898E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxGnuRegex referenced in function _ZN4onig6syntax6Syntax9gnu_regex17hd6c598f11bc55e1dE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxJava referenced in function _ZN4onig6syntax6Syntax4java17ha1302e8a57894140E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxPerl referenced in function _ZN4onig6syntax6Syntax4perl17he317d311de980de2E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxPerl_NG referenced in function _ZN4onig6syntax6Syntax7perl_ng17h2fc429af008d40a0E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigSyntaxRuby referenced in function _ZN4onig6syntax6Syntax4ruby17hdc8b4e15cda6dbcaE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol OnigDefaultSyntax referenced in function _ZN4onig6syntax6Syntax7default17hb2e74a5b26cb2cdcE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_get_syntax_op referenced in function _ZN4onig6syntax6Syntax9operators17ha7def81720d96cd7E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_get_syntax_op2 referenced in function _ZN4onig6syntax6Syntax9operators17ha7def81720d96cd7E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_set_syntax_op referenced in function _ZN4onig6syntax6Syntax13set_operators17h4f2499c704d14813E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_set_syntax_op2 referenced in function _ZN4onig6syntax6Syntax13set_operators17h4f2499c704d14813E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_get_syntax_behavior referenced in function _ZN4onig6syntax6Syntax8behavior17hc299fc6f6d2103edE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_set_syntax_behavior referenced in function _ZN4onig6syntax6Syntax12set_behavior17h9709c33bc96fd57dE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_get_syntax_options referenced in function _ZN4onig6syntax6Syntax7options17ha9ef5861970033ffE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_set_syntax_options referenced in function _ZN4onig6syntax6Syntax11set_options17h27cfc3547ca6daebE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig12.rust-cgu.o) : error LNK2019: unresolved external symbol onig_set_meta_char referenced in function _ZN4onig6syntax6Syntax13set_meta_char17h548bd228bbe586fcE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig14.rust-cgu.o) : error LNK2019: unresolved external symbol onig_version referenced in function _ZN4onig5utils7version17h0874c5989dd67b70E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig14.rust-cgu.o) : error LNK2019: unresolved external symbol onig_copyright referenced in function _ZN4onig5utils9copyright17h4eb40bbe2afc80c4E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig14.rust-cgu.o) : error LNK2019: unresolved external symbol onig_unicode_define_user_property referenced in function _ZN4onig5utils20define_user_property17h5d56c9f092ab79c1E
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig3.rust-cgu.o) : error LNK2019: unresolved external symbol OnigEncodingUTF8 referenced in function _ZN4onig7buffers12EncodedChars8encoding17hd4c6ae3888a1f41bE
          libonig-c2f134a00652abbf.rlib(onig-c2f134a00652abbf.onig3.rust-cgu.o) : error LNK2019: unresolved external symbol OnigEncodingASCII referenced in function _ZN4onig7buffers12EncodedBytes5ascii17hc75e99d22167949fE
          I:\Dev\cobalt.rs\target\debug\deps\cobalt-d5c45d3d9cdfd6ab.exe : fatal error LNK1120: 39 unresolved externals


error: aborting due to previous error

error: Could not compile `cobalt-bin`.

To learn more, run the command again with --verbose.

@Geobert
Copy link
Contributor

Geobert commented Jan 2, 2018

It works!

I had to delete my .cargo/registry folder to get rid of any bad compiled onig but it works now.

to summarize:
need to execute call "%VS140COMNTOOLS%\..\..\VC\vcvarsall.bat" amd64 that will set the PATH for us (so discard my manual setting of PATH above) and it should work!

@Geobert
Copy link
Contributor

Geobert commented Jan 2, 2018

and `--features="syntax-highlight,sass" works as well, release and debug mode!

Geobert pushed a commit to Geobert/cobalt.rs that referenced this issue Jan 2, 2018
@epage epage mentioned this issue Jan 3, 2018
Geobert pushed a commit to Geobert/cobalt.rs that referenced this issue Jan 5, 2018
apply code review comments


syntax-highlight enabled by default


add VS setup in appveyor


Try to fix appveyor


try to fix appveyor test


Fix appveyor test


Fix appveyor test


Fix appveyor test


add back --target


typo


disabling travis and set  RUST_BACKTRACE

set RUST_BACKTRACE to full


Test to fix appveyor


Try a definitive solution to cli tests


Syntax error


Syntax error


Syntax error


Restore travis, all targets (but gnu), remove  RUST_BACKTRACE


try to fix travis


try to fix travis


Restore all targets


Restore appveyor


Try a solution without copying files around


try build instead of check


Restore all targets


change to CHANNEL instead of RUST_VERSION in installation of toolchain


Remove dead code


Add --no-default-features


restore travis and add --no-default-features
Geobert pushed a commit to Geobert/cobalt.rs that referenced this issue Jan 5, 2018
apply code review comments


syntax-highlight enabled by default


add VS setup in appveyor


Try to fix appveyor


try to fix appveyor test


Fix appveyor test


Fix appveyor test


Fix appveyor test


add back --target


typo


disabling travis and set  RUST_BACKTRACE

set RUST_BACKTRACE to full


Test to fix appveyor


Try a definitive solution to cli tests


Syntax error


Syntax error


Syntax error


Restore travis, all targets (but gnu), remove  RUST_BACKTRACE


try to fix travis


try to fix travis


Restore all targets


Restore appveyor


Try a solution without copying files around


try build instead of check


Restore all targets


change to CHANNEL instead of RUST_VERSION in installation of toolchain


Remove dead code


Add --no-default-features


restore travis and add --no-default-features


Back to check for travis, avoid timeout
Geobert pushed a commit to Geobert/cobalt.rs that referenced this issue Jan 10, 2018
- Remove windows-gnu target, support of Windows only through MSVC
- Remove 32 bits support
- Switch to Visual Studio 2017 to avoid PBD error
@epage epage closed this as completed in 2549bfc Jan 15, 2018
epage added a commit that referenced this issue Jan 15, 2018
fixes #180 : Enable syntax highlight to all platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected
Projects
None yet
Development

No branches or pull requests

3 participants