-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable syntax highlighting by default on all platforms #180
Comments
I've seen this for Windows compilation issue: rust-onig/rust-onig#35
|
So it sounds like, as of last March, this should now be possible? Great! That should be a straightforward PR to implement. I think I've already removed the platform conditionals, relying only on the feature flag. So my guess as to whats left
|
I know it's possible because Gutenberg has it build on appveyor. But I tried to build Gutenberg and I have the onig_sys issue. I'm trying to build with the gnu version of the toolchain, I'll keep you posted :) |
with MSVC toolchain:
with GNU toolchain:
|
Can you build the |
Didn't work :(
|
I've found this on the subject: https://github.com/sass/libsass/blob/c943792a6e64468b66f226504a47a8160cbd2d08/docs/build.md#building-on-windows-experimental |
Ok! I was able to compile with sass after installing https://developer.microsoft.com/en-us/windows/downloads/windows-8-1-sdk for syntect, I'm missing |
I've created cobalt-org/cobalt-org.github.io#19 to track adding these requirements to the website |
after adding
|
Ok it was because of
|
It works! I had to delete my to summarize: |
and `--features="syntax-highlight,sass" works as well, release and debug mode! |
apply code review comments syntax-highlight enabled by default add VS setup in appveyor Try to fix appveyor try to fix appveyor test Fix appveyor test Fix appveyor test Fix appveyor test add back --target typo disabling travis and set RUST_BACKTRACE set RUST_BACKTRACE to full Test to fix appveyor Try a definitive solution to cli tests Syntax error Syntax error Syntax error Restore travis, all targets (but gnu), remove RUST_BACKTRACE try to fix travis try to fix travis Restore all targets Restore appveyor Try a solution without copying files around try build instead of check Restore all targets change to CHANNEL instead of RUST_VERSION in installation of toolchain Remove dead code Add --no-default-features restore travis and add --no-default-features
apply code review comments syntax-highlight enabled by default add VS setup in appveyor Try to fix appveyor try to fix appveyor test Fix appveyor test Fix appveyor test Fix appveyor test add back --target typo disabling travis and set RUST_BACKTRACE set RUST_BACKTRACE to full Test to fix appveyor Try a definitive solution to cli tests Syntax error Syntax error Syntax error Restore travis, all targets (but gnu), remove RUST_BACKTRACE try to fix travis try to fix travis Restore all targets Restore appveyor Try a solution without copying files around try build instead of check Restore all targets change to CHANNEL instead of RUST_VERSION in installation of toolchain Remove dead code Add --no-default-features restore travis and add --no-default-features Back to check for travis, avoid timeout
- Remove windows-gnu target, support of Windows only through MSVC - Remove 32 bits support - Switch to Visual Studio 2017 to avoid PBD error
fixes #180 : Enable syntax highlight to all platform
This requires either forking or patching syntect to pass the
static-libonig
flag to rust-onig, AFAIU.The text was updated successfully, but these errors were encountered: