-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split jekyll import into separate repo / binary #438
Comments
Hey, I am in favor of dumping the jekyll importer and focusing on improving the current cobalt model. Only thing I want from the jekyll implementation is the frontmatter delimiter syntax as indicated in #431. |
I've seen this yeah, I agree with your proposal but the change is not that easy to do: the code has to be modified (following edpage proposition), new tests must be created and all. So contributions are welcome :) |
Sure, if there's agreement from maintainers that this should be done I can invest some time in porting it from jekyll-model. |
I maybe wrong, but I think jekyll-model module was a refactor of my initial contribution to convert jekyll's site into cobalt's. So to support the double separator, we need to modify https://github.com/cobalt-org/cobalt.rs/blob/master/src/cobalt_model/document.rs#L46 |
@Geobert However, I could see value in pulling the import tools out into separate In general, we've taken the approach of
Sorry I wasn't clear. My comment in #431 and marking it as an enhancement were acceptance of it. I'll gladly accept a PR that makes that change. |
Good idea this split! |
Fixes cobalt-org#438 BREAKING CHANGE: Jekyll migration is removed.
Yeah, it was my idea and my first contribution to the project, but the more I look at it the more I think it was not a great idea:
Hence this ticket: shall we get rid of the feature before too many people notice it? Or deactivate it? Or at least print a giga banner saying this is pure experimental and is not working yet?
The text was updated successfully, but these errors were encountered: