Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix check-kubernetes import ordering issue #10743

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

lyandrew
Copy link
Contributor

@lyandrew lyandrew commented Dec 3, 2018

import parent has to come before import kubelib. There were other files with import parent not being first but those run without any issues.

  File "./test/verify/check-kubernetes", line 23, in <module>
    import kubelib
  File "/home/dell/cockpit/test/verify/kubelib.py", line 26, in <module>
    import testlib
ModuleNotFoundError: No module named 'testlib'

import parent
import kubelib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to avoid reintroducing this with the next automatic sorting, can you please put the import parent into its own paragraph, i. e. leave a newline after it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@martinpitt martinpitt merged commit f5c0ce0 into cockpit-project:master Dec 4, 2018
@martinpitt
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants