-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kv: don't clobber commit status when heartbeat fails
When a heartbeat failed while a request was in-flight, two proto updates could race and produce illegal behavior. For example, it was possible for a client to successfully commit but receive an ABORTED proto (and no error). This commit removes the ad-hoc manipulation of the state during heartbeat failures. Instead, before each new request sent through the heartbeat interceptor we check on the heartbeat loop's status; if it indicates an error, we refuse new requests. Fixes #39658. Release note: None
- Loading branch information
Showing
2 changed files
with
34 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters