Skip to content

Commit

Permalink
Merge #41275
Browse files Browse the repository at this point in the history
41275: roachtest: skip cdc/crdb-chaos/rangefeed=true r=tbg a=danhhz

This max latency failure is definitely interesting and worth looking
into, but not now. It does seem to always get itself started back up,
just taking much longer than we'd expect (this assertion really should
be around 2m, but we've upped it to try and reduce flakes). I don't
think we get a lot of value from running this every night, especially
while cdc is not under active development. I'm going to skip this in the
interest of reducing noise.

Release justification: non-production code changes

Release note: None

Co-authored-by: Daniel Harrison <daniel.harrison@gmail.com>
  • Loading branch information
craig[bot] and danhhz committed Oct 3, 2019
2 parents 3bc423c + 221a0a8 commit c0e8390
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/cmd/roachtest/cdc.go
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@ func registerCDC(r *testRegistry) {
})
r.Add(testSpec{
Name: fmt.Sprintf("cdc/crdb-chaos/rangefeed=%t", useRangeFeed),
Skip: "#37716",
// TODO(dan): Re-enable this test on 2.1 if we decide to backport #36852.
MinVersion: "v19.1.0",
Cluster: makeClusterSpec(4, cpu(16)),
Expand Down

0 comments on commit c0e8390

Please sign in to comment.