-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
42198: colexec: clean up remapping of indexed vars for filter expressions r=yuzefovich a=yuzefovich **colexec: fix handling of filters by joiners** Previously, in order to handle ON expression of the joiners, we would modify the expression itself (i.e. we would remap the IndexedVars inside of the expression). However, this approach is error-prone and doesn't work in all cases (consider an example when we have a filter like "@1 = 'abc@2def'" - @2 is not an ordinal, but it would get treated as an IndexedVar with index 1). Now we have enhanced the IndexedVarHelper to handle the remapping internally when the IndexedVar is being bound to a container. This way no modifications to the actual expressions are needed, and such approach should work in all cases. Fixes: #41407. Fixes: #41944. Fixes: #42100. **sem/tree: remove unused field from IndexedVar** This commit removes 'bindInPlace' field from IndexedVar struct since it is not being used anywhere. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
- Loading branch information
Showing
5 changed files
with
134 additions
and
102 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.