Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ttljob: add hint to use PK in delete/select query #118336

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 26, 2024

Backport 1/1 commits from #118318 on behalf of @rafiss.

/cc @cockroachdb/release


This will help avoid choosing a plan that scans a secondary index, which can lead to many KV rows being scanned and also lead to contention.

This updates the query used for both SELECTs and DELETEs so that they
use the primary index.

informs #82140

Release note (bug fix): Fixed a bug that could cause DELETE queries sent by the row-level TTL job to use a secondary index rather than the primary index to find the rows to delete. This could lead to some DELETE operations taking a much longer time than they should. This bug was present since v22.2.0.


Release justification: bug fix

@blathers-crl blathers-crl bot requested a review from a team as a code owner January 26, 2024 00:47
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-118318 branch from b4e6c85 to c2068d4 Compare January 26, 2024 00:47
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 26, 2024
Copy link
Author

blathers-crl bot commented Jan 26, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 26, 2024
Copy link
Author

blathers-crl bot commented Jan 26, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @annrpom and @michae2)

@rafiss rafiss requested a review from mgartner January 26, 2024 15:06
This will help avoid choosing a plan that scans a secondary index, which
can lead to many KV rows being scanned and also lead to contention.

This updates the query used for both SELECTs and DELETEs so that they
use the primary index.

Release note (bug fix): Fixed a bug that could cause DELETE queries sent
by the row-level TTL job to use a secondary index rather than the
primary index to find the rows to delete. This could lead to some DELETE
operations taking a much longer time than they should. This bug was
present since v22.2.0.
@rafiss rafiss changed the title release-23.1: ttljob: add hint to use PK in delete query release-23.1: ttljob: add hint to use PK in delete/select query Jan 29, 2024
@rafiss rafiss force-pushed the blathers/backport-release-23.1-118318 branch from c2068d4 to 485b0f1 Compare January 29, 2024 16:13
@rafiss
Copy link
Collaborator

rafiss commented Jan 29, 2024

i decided to just update the commit message

@rafiss rafiss merged commit 78d7c48 into release-23.1 Jan 29, 2024
6 checks passed
@rafiss rafiss deleted the blathers/backport-release-23.1-118318 branch January 29, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants