-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: ttljob: add hint to use PK in delete/select query #118336
Conversation
b4e6c85
to
c2068d4
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @annrpom and @michae2)
This will help avoid choosing a plan that scans a secondary index, which can lead to many KV rows being scanned and also lead to contention. This updates the query used for both SELECTs and DELETEs so that they use the primary index. Release note (bug fix): Fixed a bug that could cause DELETE queries sent by the row-level TTL job to use a secondary index rather than the primary index to find the rows to delete. This could lead to some DELETE operations taking a much longer time than they should. This bug was present since v22.2.0.
c2068d4
to
485b0f1
Compare
i decided to just update the commit message |
Backport 1/1 commits from #118318 on behalf of @rafiss.
/cc @cockroachdb/release
This will help avoid choosing a plan that scans a secondary index, which can lead to many KV rows being scanned and also lead to contention.
This updates the query used for both SELECTs and DELETEs so that they
use the primary index.
informs #82140
Release note (bug fix): Fixed a bug that could cause DELETE queries sent by the row-level TTL job to use a secondary index rather than the primary index to find the rows to delete. This could lead to some DELETE operations taking a much longer time than they should. This bug was present since v22.2.0.
Release justification: bug fix