githooks: just update submodule on ref changes

[dt]

with deps now managed by the scm directly (the vendor submodule), we don't need to run glock or make during scm operations

---

This change is 

[tamird]

---

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

githooks/post-rewrite, line 4 at r1 (raw file):

set -e

# TODO(dt): do we want to submomdule update here?

it's pretty cheap, why not?

---

Comments from Reviewable

[dt]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

githooks/post-rewrite, line 4 at r1 (raw file):

Previously, tamird (Tamir Duberstein) wrote…

it's pretty cheap, why not?

I'll add it if it turns out we want it, but I'm thinking we can just nuke this hook instead?

---

Comments from Reviewable

[tamird]

I don't remember what this particular hook was here for, so do what you think is best.

…

On Tue, Dec 6, 2016 at 10:17 AM, David Taylor ***@***.***> wrote: Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. ------------------------------ *githooks/post-rewrite, line 4 at r1 <https://reviewable.io:443/reviews/cockroachdb/cockroach/12088#-KYJh39H0iEYhZ0sUnS6:-KYJhK_tDdF96W0Jc5fS:b-ijewaf> (raw file <https://github.com/cockroachdb/cockroach/blob/3f06d9b5a0fcad823f2a32774546925884e5c2fa/githooks/post-rewrite#L4>):* *Previously, tamird (Tamir Duberstein) wrote…* it's pretty cheap, why not? I'll add it if it turns out we want it, but I'm thinking we can just nuke this hook instead? ------------------------------ *Comments from Reviewable <https://reviewable.io:443/reviews/cockroachdb/cockroach/12088>* — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#12088 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABdsPE3vrxY0CZwcBmAwz4xOp6K-6I9Wks5rFXySgaJpZM4LFeSM> .

[dt]

The internet seems to think we just need post-merge and post-checkout, so I'll start there. If we decide we're missing post-rewrite, it's quick to add it.

---

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

Comments from Reviewable

[bdarnell]

IIRC git pull --rebase runs post-rewrite but not post-merge or post-checkout. You have to resync the submodule because the branch being rebased onto might have updated it.