Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: alphabetize imports #127650

Merged
merged 1 commit into from
Jul 25, 2024
Merged

ui: alphabetize imports #127650

merged 1 commit into from
Jul 25, 2024

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Jul 23, 2024

This commit modifies the imports/order eslint rule to also enforce that imports are alphabetically ordered by import path.

Epic: none

Release note: None

@xinhaoz xinhaoz requested a review from a team as a code owner July 23, 2024 20:02
@xinhaoz xinhaoz requested review from dhartunian and removed request for a team July 23, 2024 20:02
Copy link

blathers-crl bot commented Jul 23, 2024

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz xinhaoz changed the title db-console: alphabetize imports ui: alphabetize imports Jul 24, 2024
Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@xinhaoz xinhaoz force-pushed the alphabetize-imports branch 2 times, most recently from 4a5d262 to 4829405 Compare July 25, 2024 12:16
This commit modifies the imports/order eslint rule to also
enforce that imports are alphabetically ordered by import path.

Epic: none

Release note: None
@xinhaoz
Copy link
Member Author

xinhaoz commented Jul 25, 2024

bors r+

@craig craig bot merged commit 2782d5c into cockroachdb:master Jul 25, 2024
22 checks passed
@xinhaoz xinhaoz deleted the alphabetize-imports branch July 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants