Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: some improvements to TestDropTable #13971

Merged
merged 1 commit into from
Mar 8, 2017
Merged

sql: some improvements to TestDropTable #13971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/sql/drop_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,9 @@ func TestDropTable(t *testing.T) {
runFunc := runAfterTableNameDropped
runAfterTableNameDropped = nil
if runFunc != nil {
err := runFunc()
go func() {
errChan <- runFunc()
errChan <- err
}()
// Return an error so that the DROP TABLE is retried.
// This tests the idempotency of DROP TABLE.
Expand Down Expand Up @@ -382,7 +383,7 @@ func TestDropTable(t *testing.T) {
if _, err := sqlDB.Exec(
`SELECT * FROM t.kv`,
); !testutils.IsError(err, `table "t.kv" does not exist`) {
return errors.Wrap(err, "different error than expected")
return errors.Errorf("different error than expected: %+v", err)
}

if gr, err := kvDB.Get(ctx, nameKey); err != nil {
Expand Down