cmd/benchmark: don't upload "name" #16816
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be the actual benchmark name which is parsed out by the server; setting it manually results in a uniqueness violation.
|
This change is |
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
m-schneider
pushed a commit
to m-schneider/cockroach
that referenced
this pull request
Jun 30, 2017
cmd/benchmark: don't upload "name"
tamird
referenced
this pull request
in golang/perf
Jul 1, 2017
This adds an undocumented "raw=1" query parameter to visualize raw results without any averaging or filtering. Results are colored according to the upload-part they came from. Change-Id: I25590ace89dfe55380e28182c38aeb223e2e73b9 Reviewed-on: https://go-review.googlesource.com/37160 Run-TryBot: Quentin Smith <quentin@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the actual benchmark name which is parsed out by the
server; setting it manually results in a uniqueness violation.